search

NeverBounce / NeverBounceApi-DotNet

MIT License
4 stars 7 forks source link

.Net Standard Version #5

Open jag43 opened 5 years ago

jag43 commented 5 years ago

It would be great to have a .NetStandard version/target for the NeverBounceSDK project so we can consume this from our ASP.NetCore web applications.

mmollick commented 5 years ago

@jag43 thanks for the suggestion. After some brief research, it certainly sounds like a good idea. However, we don't have any .Net gurus on our team to keep up with the ecosystem; so it may be some time until we get around to implementing this change. We would be open to PRs in the meantime.

Yinamil commented 4 years ago

I know this is old, but I can look into doing this. I don't think I'd be able to devote a ton of time, but if I get the implementation over to a NetStandard project, I'm sure it can be easily maintained. I'll have to have access to make pull requests without manually editing the files on the git repo itself. I added a fix to the Issue #12 but don't have write access so I couldn't push my branch. I had to manually edit the file in github itself, which is not ideal for converting this to .NetStandard.

mmollick commented 4 years ago

@aareaux That would be much appreciated. My biggest concern is introducing backwards compatibility issues for existing users of the library.

In regards to write access, that shouldn't be necessary. You should be able to fork the project, commit your changes to your fork and then create a PR back to this project when you're done.

Yinamil commented 4 years ago

@mmollick I would think you'd want to have a separate nuget for the .NetStandard version altogether. Could just name it something with 'AspNetCore' in it or something similar to distinguish between the two. If you want to create a new Git Repo for it, that would probably work better. I'll start working on porting it over.

VagueGit commented 4 years ago

Rather than calling the NetStandard version AspNetCore, which implies AspNetCore projects only and does not include other NetCore projects, might I suggest a name along the lines of NetCore version or Net5 version? NetCore is becoming Net5.

pundj commented 3 years ago

Fix submitted in #16

KeithHenry commented 1 year ago

5 years later standard and core have merged since .NET 5

Current version of .NET is 7, PR #20 is a complete update to 7 along with lots of other fixes and .NET compatibility changes.