Even though it might look stupid rendering the json through the whole pipeline, I think this is a necessary effort for now because:
1) rendering logic should reside on the renderer
2) for the future, I plan don't plan to neither store the CV as a json in our database, nor send it through the webapp to the API (maybe the API will get it directly from the DB), so it makes sense that we do not download it directly.
On a side node, the code on the renderer side is really bad, but I couldn't think of any better way to do it without major refactoring (which I don't want to do now and it should be done for the whole renderer code), so I just made it work
ramonsaboya
commented
4 years ago
Even though it might look stupid rendering the json through the whole pipeline, I think this is a necessary effort for now because: 1) rendering logic should reside on the renderer 2) for the future, I plan don't plan to neither store the CV as a json in our database, nor send it through the webapp to the API (maybe the API will get it directly from the DB), so it makes sense that we do not download it directly.
On a side node, the code on the renderer side is really bad, but I couldn't think of any better way to do it without major refactoring (which I don't want to do now and it should be done for the whole renderer code), so I just made it work