search

NevermindNilas / TheAnimeScripter

Welcome to TheAnimeScripter – the ultimate tool for Video Upscaling, Interpolating and many more. Available as a CLI, GUI and Adobe Extension.
GNU Affero General Public License v3.0
95 stars 1 forks source link

GUI: Support defining custom encoding settings #36

Closed przemoc closed 3 months ago

przemoc commented 4 months ago

Until user does final encoding pass (which may not necessarily happen in TAS), user may want to work with lossless or almost lossless quality.

E.g. for x264 it may be -c:v libx264 -crf 0 -profile:v high444 -pix_fmt yuv444p10le or -c:v libx264 -crf 0 -profile:v high444 -pix_fmt yuv444p

There may be other valid reasons to have custom encoding settings.

NevermindNilas commented 4 months ago

TAS used to be hardcoded to decode in rgb24 raw so it was working as lossless throughout the process as it could.

Ever since switching to decord I lost track of it but I didn't see any color shifts or abnormalities at least visually when comparing 1.8.0 results to newer releases ( 1.8.5 specifically ).

As for encoding, TAS does technically support --custom_encoder which does provide more granularity to the encoding parameters but it can easily break how TAS works. This feature has yet to be added to the standalone GUI but it is present in the After Effects GUI.

przemoc commented 4 months ago

Oh, I see. Sorry for overlooking --custom_encoder. So I guess the issue remains only on standalone GUI side of things.

NevermindNilas commented 3 months ago

Finished.

przemoc commented 3 months ago

Month ago, after I realized custom encoding settings were available in CLI, but not in GUI, I renamed issue to make it strictly GUI related. You closed a few days ago, yet I do not see any improvements in GUI related to that in v1.9.0, so I think it should be kept open. Did I miss anything?

NevermindNilas commented 3 months ago

Hi,

As stated in the release 1.9.0 Standalone GUI with TAURI: GUI.exe is no longer going to be maintained in favor of Tauri for a planned 2.0.0 release.

I will no longer be maintaining the current iteration of the GUI and will instead focus on an alternative with TAURI at its core. That one already has a 'half baked' custom encoder in it.

The current GUI is just frankly bad and I am not happy with constantly releasing the GUI with a ' maybe works ' state.

przemoc commented 3 months ago

Thank you for explaining.