Nevuly / WSL2-Rolling-Kernel-Issue

Rolling Release Kernel for WSL2 Issue Report Repository
0 stars 0 forks source link

[BUG][OLD] Logic in modules-install.sh is broken #12

Closed juergenpf closed 3 months ago

juergenpf commented 3 months ago

IMHO the logic of the file checking in modules-install.sh is broken.

Lets assume, the first file you check doesn't exist. Then you set file_checker=0. If now the next file exists, you overwrite that immediately with file_checker=1. When you then at the end check the value, you'll never notice, that the first file was missing. You need to rework this.

Nevuly commented 3 months ago

@juergenpf

Hello, Thanks for leaving issue!

I'll apply more better file check solution in installer script.

Thanks!

Nevuly commented 3 months ago

@juergenpf

I fixed modules-install.sh script file check process.

You can check script in below:

https://gist.github.com/Nevuly/cf1d17db72cdfde6ed149461eef0215c

Thanks!