NewAmazingPVP / AutoUpdatePlugins

Automatically update any spigot/bungeecord/velocity plugin you wish!
MIT License
11 stars 2 forks source link

Modrinth and CurseForge Links #10

Closed SkyKingPX closed 5 months ago

SkyKingPX commented 8 months ago

Hello, I wanted to ask if Modrinth and CurseForge links are working in the list.yml.

if not, it would be nice to see it in the next update 😉

NewAmazingPVP commented 5 months ago

Hey there, @SkyKingPX, I am so sorry for being so late; I almost forgot about this. I have added beta Modrinth support and am working on CurseForge. Here is the build. Because of how modrinth links are currently, you want to put it this way: [modrinth link] [project ID] like https://modrinth.com/plugin/simple-voice-chat/9eGKb6K1. You can get the project ID at the bottom left of the page. image image

NewAmazingPVP commented 5 months ago

Please test it out and let me know if it works as intended.

SkyKingPX commented 5 months ago

Thank you, I will

NewAmazingPVP commented 5 months ago

Hey @SkyKingPX, you can also try this build, it should make it so you can directly put the link in without projectID and should work. The only downside right now is that it only supports spigot jars, but I am working on adding others.

SkyKingPX commented 5 months ago

So try both @NewAmazingPVP ?

NewAmazingPVP commented 5 months ago

Actually, I am sorry for all the confusion, just try this build. It has support for all platforms

NewAmazingPVP commented 5 months ago

Just try that one only, thanks!

SkyKingPX commented 5 months ago

@NewAmazingPVP But it is a plugin. Or is it a mod? The question is if I can download Mods on Forge/Fabric and Plugins from CurseForge and Modrinth. The picture that you posted confuses me...

NewAmazingPVP commented 5 months ago

Hey, this is a plugin, don't worry too much about the picture, as it might confuse you more. Basically, for example, voicemod is a bukkit plugin, and if you put this link in https://modrinth.com/plugin/simple-voice-chat, it should automatically update to its latest version.

SkyKingPX commented 5 months ago

Oh wow I didn't know that it is also a plugin

NewAmazingPVP commented 5 months ago

@SkyKingPX It will automatically detect if it is a mod or plugin, and it will only download plugins. 

NewAmazingPVP commented 5 months ago

Oh wow I didn't know that it is also a plugin

Yeah, it's both a mod and a plugin, it will only download its plugin jar though based on what platform.

SkyKingPX commented 5 months ago

@NewAmazingPVP I can't download the file. The speed is way to slow. I can download other files but not that one

SkyKingPX commented 5 months ago

grafik

NewAmazingPVP commented 5 months ago

Ok, no pressure whenever it works. Also, you can choose your own modrinth plugin to test it out and don't have to use voicemod. I just showed that as an example. 

NewAmazingPVP commented 5 months ago

But thanks for your help!

SkyKingPX commented 5 months ago

I used "SimpleVoiceChat: https://modrinth.com/plugin/simple-voice-chat" but it didn't save the file - it isn't in the plugins folder

NewAmazingPVP commented 5 months ago

Alright, looking into it!

SkyKingPX commented 5 months ago

In this time I'll try changing the link

SkyKingPX commented 5 months ago

"SimpleVoiceChat: https://modrinth.com/plugin/simple-voice-chat/" didn't work either

SkyKingPX commented 5 months ago

It is also stuck, so it doesn't download the plugins after this entry in the list.yml @NewAmazingPVP

NewAmazingPVP commented 5 months ago

@SkyKingPX I fixed it, it was a simple issue that it didn't retrieve the project id. Here's the build

SkyKingPX commented 5 months ago

@NewAmazingPVP Yes Modrinth works now. Now I'll try CF

SkyKingPX commented 5 months ago

@NewAmazingPVP

[18:28:48 INFO]: [AutoUpdatePlugins] [STDOUT] Failed to download plugin: Server returned HTTP response code: 403 for URL: https://www.curseforge.com/minecraft/bukkit-plugins/worldedit/
[18:28:48 WARN]: java.io.IOException: Server returned HTTP response code: 403 for URL: https://www.curseforge.com/minecraft/bukkit-plugins/worldedit/
[18:28:48 WARN]:    at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:2011)
[18:28:48 WARN]:    at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1602)
[18:28:48 WARN]:    at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:223)
[18:28:48 WARN]:    at autoupdateplugins-1.0.jar//common.UpdatePlugins.updatePlugin(UpdatePlugins.java:55)
[18:28:48 WARN]:    at autoupdateplugins-1.0.jar//common.UpdatePlugins.lambda$readList$0(UpdatePlugins.java:183)
[18:28:48 WARN]:    at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
[18:28:48 WARN]:    at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796)
[18:28:48 WARN]:    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
[18:28:48 WARN]:    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
[18:28:48 WARN]:    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
[18:28:48 WARN]:    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
[18:28:48 WARN]:    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
NewAmazingPVP commented 5 months ago

Hey, @SkyKingPX, so I looked in CF, but I have to sadly mention that I cannot add that because of the terms in their API.  Here's the reason: https://github.com/CubeCoders/AMP/issues/686  (Tldr: It can cost money for calls.) Plus, authors of plugins on CurseForge have the option to disallow users from downloading their mods. So therefore, with the reasons in that thread and such, I would like to stay away from CF. That being said, I have added support for dev.bukkit.org and other platforms that have all the plugins that CF has. Unless I am mistaken, are there any plugins exclusive to CF?

NewAmazingPVP commented 5 months ago

@SkyKingPX Try this link, https://dev.bukkit.org/projects/worldedit That should work!

NewAmazingPVP commented 5 months ago

Almost all curseforge plugins have alternative on bukkit.org, which already has a support.

SkyKingPX commented 5 months ago

Unless I am mistaken, are there any plugins exclusive to CF?

I don't know.

@SkyKingPX Try this link, https://dev.bukkit.org/projects/worldedit That should work!

I used this one before

SkyKingPX commented 5 months ago

But still thanks for at least Modrinth :)

NewAmazingPVP commented 5 months ago

@SkyKingPX I am confused, does this link not work? https://dev.bukkit.org/projects/worldedit If so I have to fix that.

NewAmazingPVP commented 5 months ago

But thank you for your help testing this out. And anytime, I am glad to implement any ideas you have!

SkyKingPX commented 5 months ago

@SkyKingPX I am confused, does this link not work? https://dev.bukkit.org/projects/worldedit If so I have to fix that.

It does

SkyKingPX commented 5 months ago

No error and the timestamp is also correct grafik grafik

NewAmazingPVP commented 5 months ago

Perfect, great!