NewAmazingPVP / AutoUpdatePlugins

Automatically update any spigot/bungeecord/velocity plugin you wish!
MIT License
11 stars 2 forks source link

Error downloading Spiget #8

Closed SkyKingPX closed 10 months ago

SkyKingPX commented 10 months ago

Hello, every time I start my server and the Plugin tries to download the Plugins this error shows up (only one time). image

I don't know if another Plugin causes this, so here are my plugins and my list.yml (converted into txt because of github): list.txt Screenshot 2024-01-09 164751

NewAmazingPVP commented 10 months ago

In your console error log could you show me the plugin it tried downloading before the error happened? Looks like it's the headdrops plugin but I want to be sure

SkyKingPX commented 10 months ago

Yes it’s HeadDrop @NewAmazingPVP

NewAmazingPVP commented 10 months ago

@SkyKingPX try putting in this link https://www.spigotmc.org/resources/%E2%9C%85-headdrop-free-1-16-1-20-fully-customizable.99976/

instead of https://www.spigotmc.org/resources/99976/

SkyKingPX commented 10 months ago

Yes, works now. Thanks and this is a great plugin!

(Btw the Console says you should use Plugin logger (JavaPlugin#getLogger) instead of Sytem.out/err.print)

NewAmazingPVP commented 10 months ago

Great! The problem was the regex pattern extracting the plugin ID from the link. Currently, it looks for something like this ".123/" but since you used the normal resources link, it couldn't find a dot followed by numbers and slash. I am probably going to release next version which will fix this, thus making it simpler to use the plugin.

NewAmazingPVP commented 10 months ago

Also @SkyKingPX I just released the new version https://github.com/NewAmazingPVP/AutoUpdatePlugins/releases/download/v6.5/autoupdateplugins-6.5.jar

With this version it won't matter if you use https://www.spigotmc.org/resources/99976/ or https://www.spigotmc.org/resources/%E2%9C%85-headdrop-free-1-16-1-20-fully-customizable.99976/ both links will work

Also, I have taken your suggestion into consideration and have long thought so doing separate loggers for all platforms but just don't have the time to recode, but I'll try if I do get time.

NewAmazingPVP commented 10 months ago

The logger thing is not an error though the plugin should work fine as it is. It's just not the most preferred way to log/send messages, therefore it's saying that.

SkyKingPX commented 10 months ago

I know.

But why is the plugin Version 6.5 instead of 6.1???

SkyKingPX commented 10 months ago

@NewAmazingPVP

NewAmazingPVP commented 10 months ago

My version naming convention is pretty bad; don't question it, lol. Currently, it's +0.5 for minor updates and +1.0 for major updates. This is not a good way to do the version naming, so I was thinking to restart over starting off with 1.6, 1.65, 1.7, etc., but that's just a small thing not to worry about right now.

SkyKingPX commented 10 months ago

Ok.

But a better way would be for example: 1.0 1.1 1.2 1.2.1

NewAmazingPVP commented 10 months ago

Yeah I agree