NewChromantics / PopH264

Low-level, minimal H264 decoder & encoder library for windows, hololens/uwp, ios/tvos/macos, linux, android/quest/magic leap. CAPI for use with c#, unreal, swift
http://poph264.com/
Mozilla Public License 2.0
84 stars 15 forks source link

When android build fails, github action reports success #39

Closed SoylentGraham closed 3 years ago

SoylentGraham commented 3 years ago

This includes the action's entrypoint.sh syntax errors. (Maybe only the old @v1)

Lets FORCE an error if there are no .so's or some significant files in the output.

Artifact output is this (so there IS a file.... but probably not the one we want) https://github.com/NewChromantics/PopH264/runs/1838584005?check_suite_focus=true


Total size of all the files uploaded is 2827 bytes
Finished uploading artifact Android. Reported size is 2827 bytes. There were 0 items that failed to upload
Artifact Android has been successfully uploaded!```
SoylentGraham commented 3 years ago

Updated create release build with v2 d7ae00d5a3ed8a3dd64e3b0922c79f7b642528df but we should add some safety net

ink-pot-monkey commented 3 years ago

Changed the Android action to use a bash script and added Bash Error Handling to exit if any errors are detected with

set -Ee