search

NewChromantics / PopH264

Low-level, minimal H264 decoder & encoder library for windows, hololens/uwp, ios/tvos/macos, linux, android/quest/magic leap. CAPI for use with c#, unreal, swift
http://poph264.com/
Mozilla Public License 2.0
83 stars 15 forks source link

Osx XCFramework "corrupted" again #41

Open SoylentGraham opened 3 years ago

SoylentGraham commented 3 years ago

“PopH264_Osx.framework” is damaged and can’t be opened. You should move it to the Bin. Need to make sure no .meta's are being copied in post-build (cause last time)

Maybe we can add some post build step in the action to check/verify the state of the framework. (Maybe codesign will do this)

SoylentGraham commented 3 years ago

edit: a step way after building, but before pushing release

ink-pot-monkey commented 3 years ago

For codesigning the mac framework it doesnt seem that we can add any extra files to the root of the framework. Currently all the meta files are added to the resources folder of the framework, until we figure out another approach. Ios is fine

ink-pot-monkey commented 3 years ago

Creating a release workflow has a step in it to check the codesign, however this is disabled for 2 reasons.

  1. There is an error on the runner that: PopH264.Package/PopH264.xcframework/macos-x86_64/PopH264_Osx.framework: bundle format is ambiguous (could be app or framework) which wasnt the case when building locally

  2. This step needs to be run on a macos machine in order to have access to the codesign command but this clashes with the Make github release step which is a linux container action fnkr/github-action-ghr@v1 which can only be run on a linux runner.

https://github.com/NewChromantics/PopH264/blob/b43ce6d8a0d0604be9b73283aa2dd72294ee1ac6/.github/workflows/Create_Release.yml#L151