search

NewEagleRaptor / raptor-dbw-ros

New Eagle drive-by-wire development kit - Not actively maintained
BSD 3-Clause "New" or "Revised" License
30 stars 18 forks source link

Warnings on loading dbc files #33

Open MCFurry opened 4 years ago

MCFurry commented 4 years ago

I have been using the 'can_dbc_parser' for quite a while with pleasure, thanks for this package!

Unfortunately though, upon loading any dbc file, I always get some warnings: LineParser Exception: [Unexpected end of line.] LineParser Exception: [Nothing found in search space.]

It seems these warnings also appear upon loading one of your dbc files: https://github.com/NewEagleRaptor/raptor-dbw-ros/blob/master/raptor_dbw_can/New_Eagle_DBW_3.3.388.dbc

So I suspect this is rather a parser thing then an invalid dbc file? The warnings monstly seem to be triggering on the 'new symbols' part on top of the file and any multiline description?

NewEagleRaptor commented 4 years ago

This seems to be an issue with the dbc file parser. The biggest indicator of a rogue dbc parser error is whether-or-not it outputs that your dbc file object has the correct number of messages. So far, I've seen the warnings but not seen any failures in parsing with another project--so from a practical standpoint, I wouldn't worry but this does need fixed

MCFurry commented 4 years ago

I agree functional wise the parser seems to do a good job! We just noticed a lot of warnings appear in our projects. Then I saw it does the same with one of your dbc files so was a bit surprised ;-)