search

NewEraCracker / LOIC

Deprecated - Low Orbit Ion Cannon - An open source network stress tool, written in C#. Based on Praetox's LOIC project. USE ON YOUR OWN RISK. WITHOUT ANY EXPRESS OR IMPLIED WARRANTIES. IF YOU GET V& IT IS YOUR FAULT.
https://github.com/NewEraCracker/LOIC/
Other
2.64k stars 649 forks source link

James Matchett- Add ICMP attack method #67

Closed JamesMatchett closed 7 years ago

JamesMatchett commented 7 years ago

Hopefully Commit coming through clearer now,

As per issue #64

Adds the option for ICMP (ping flood) attacks either with no data in the buffer sent with the ping or a random amount of random bits (up to 65500) in the buffer.

Random bits selected with the "Append random chars" checkbox when ICMP is selected in the method box and number of pings per thread selected with Sockets/thread when ICMP is selected.

Things I would change: Drop port number from ICMP method call in cHLDos.cs as it is unnecessary in ICMP pings. I would also like to go over the GUI checkboxes selectable when ICMP is selected.

Thanks a bunch, James

NewEraCracker commented 7 years ago

Looks good. Thanks a lot. I may do some changes before integrating on master.

JamesMatchett commented 7 years ago

That's brilliant, thank you very much :)- James

NewEraCracker commented 7 years ago

Have you pushed the latest commit through browser or git client? It introduced a gigantic amount of whitespace changes.

JamesMatchett commented 7 years ago

Apologies, bad commit on my part a few mintues ago, I was being an idiot and uploaded to the wrong branch of mine. I can't get the git client installed where I am during studies and wanted to save a small change to a different branch. I can revert it as soon as I get back home, I'm so sorry for adding to the workload, I'll get it done asap.

JamesMatchett commented 7 years ago

Hi, sorry again for the stupid mistake, I've pushed the files from git desktop from home. I tried pushing the master then pushing my changes after that so changes only would be highlighted. The large diff number is still appearing. Do you think a new pull request would be the easiest option or is there a better way?

Sorry again, James

NewEraCracker commented 7 years ago

Yeah, just do another pull request. Sorry for the hassle.

JamesMatchett commented 7 years ago

not a problem, I've learnt my lesson, stick to git dekstop from now on. Will have that done soon :)