search

NewGraphEnvironment / fish_passage_skeena_2023_reporting

https://newgraphenvironment.github.io/fish_passage_skeena_2023_reporting
Creative Commons Zero v1.0 Universal
0 stars 2 forks source link

Edit dfo stock assessment data table so its all dark #62

Open NewGraphEnvironment opened 4 months ago

NewGraphEnvironment commented 4 months ago

We will need to do it for all the watershed groups so can maybe provide it all in one place in a sortable/filterable table in the interactive report (and just point to a link in the pdf version) .

lucy-schick commented 1 month ago

The data has been added to the report. The table needs to be edited so its all the same colour. Table can be found here https://www.newgraphenvironment.com/fish_passage_skeena_2023_reporting/background.html#salmon-stock-assessment-data

NewGraphEnvironment commented 1 month ago

spent extensive time with this table to get it to be functional

latest template for how to make table is in https://github.com/NewGraphEnvironment/staticimports (ng branch). This is a locally built package as per https://github.com/NewGraphEnvironment/mybookdown-template/issues/56 . staticimports provides solution for shifting development of functions. version of my_dt_table in staticimports not likely suitable for this use case but still relevant

Details on dark mode, links to DT issues and associated idiosyncrasies so far are here - https://github.com/NewGraphEnvironment/mybookdown-template/issues/54 .

These type of issues are often overcome using right-click inspect element in browser and modifying .css files accordingly. Sometimes it makes more sense to just not have the report be dark (went that route for Peace 2023) or live with things that are not perf

increasing width of report as per https://github.com/NewGraphEnvironment/mybookdown-template/issues/55 may deal with stacked pagination resulting from style = 'bootstrap' (bootstrap deals with visibility of pagenation which seemed like larger issue)