search

NewGraphEnvironment / fpr

Fish Passage Reporting functions for British Columbia
http://www.newgraphenvironment.com/fpr/
Other
2 stars 2 forks source link

`fpr_create_hydrograph` #60

Open NewGraphEnvironment opened 8 months ago

NewGraphEnvironment commented 8 months ago

https://github.com/NewGraphEnvironment/fpr/pull/59 20240221

  1. wonderful start. some of below might already be done. reviewing multiple commits so easy to miss
    • [x] 2. make "fig/hydrologystats" and the other output a param (look for examples of dir_stub_out naming conventions in other functions - not sure if there is any). remove ./ from front filepath (not necessary)
    • [x] 3. call all functions explicitly (ex. tidyr::tidyhat_info)
    • [x] 4. make sure all funcitons are @importFrom (done I think)
    • [x] 5. call the hydrograph1_stats_caption for both outputs using a message so it prints to the console and can be pasted into the chunk header. Use cli for message as per new rfp funcitons or as per fpr_dbq function method
    • [x] 6. remove the hashed out flow_UDR text. Test the other hashed out text to see if it is helpful. guessing not. Can prob remove. if looks really helpful lets leave and make note of how we might include in issue (if with param calls maybe)
    • [x] 7. make in function sanity tests to give informative error messages to the user. Use chk from Poisson when possible and see examples in https://github.com/NewGraphEnvironment/fpr/blob/main/R/fpr_sp_assign_sf_from_utm.R
    • [x] 8. change the name of the R file so it does not start with a t
lucy-schick commented 1 week ago

A static version of this function (sfpr_create_hydrograph) has been added to staticimports here https://github.com/NewGraphEnvironment/staticimports/blob/ng/inst/staticexports/ng_fpr.R#L64

lucy-schick commented 1 week ago

A more up to date version of this function with quartiles can now be found here https://github.com/NewGraphEnvironment/nrp_vis_2024/blob/main/0600-nutrient-loading.Rmd#L410C1-L471C4.

Moving forward we should: