May as well put as stand alone script to avoid shopping around in spatial.R at the same time
Can be tested for backwards compatibility using past fp repo scripts in scripts/02_reporting/0170-load_wshd_stats.R
no action required now but:
Considering eventually moving fpr_sp functions that are not really "fish passage reporting spatial" specific (especially when stream_crossing_id is parameterized) to separate package
This function has always been called as part of report setup (vs build) so deprecating completely after move will not break any past reports but perhaps just a note to user (and badge) in the help that there is a new function somewhere (superseded) would work fine and allow updates to watershed areas using unaltered historic repo scripts if required...
Add param
col_idwith defaultstream_crossing_idto allow backwards compatibility and future flexibility for content of dataframe provided. Should work to address watershed area generation for https://github.com/NewGraphEnvironment/fish_passage_fraser_2023_reporting/issues/59https://github.com/NewGraphEnvironment/fpr/blob/b9eb9d344740d6b8f83200e5a0ef0de66ddcb5fd/R/spatial.R#L30
May as well put as stand alone script to avoid shopping around in
spatial.Rat the same timeCan be tested for backwards compatibility using past fp repo scripts in
scripts/02_reporting/0170-load_wshd_stats.Rno action required now but: Considering eventually moving
fpr_spfunctions that are not really "fish passage reporting spatial" specific (especially whenstream_crossing_idis parameterized) to separate packageThis function has always been called as part of report setup (vs build) so deprecating completely after move will not break any past reports but perhaps just a note to user (and badge) in the help that there is a new function somewhere (superseded) would work fine and allow updates to watershed areas using unaltered historic repo scripts if required...