move `fpr_xref_pscis_modelled` to `rfp` generalized as `rfp_bcd_get_data`

[NewGraphEnvironment]

could be any bcdata table with any filter/select combo. will come in handy for more than just fish passage

[NewGraphEnvironment]

just to put this somewhere as really it is a simple query multiple ways that doesn't need a function

# we can also get it like this:
xref_pscis_my_crossing_modelled <- fpr::fpr_db_query(
  query= "SELECT external_crossing_reference, stream_crossing_id
  FROM whse_fish.pscis_assessment_svw 
  WHERE FUNDING_PROJECT_NUMBER = 'skeena_2023_Phase1'"
) |>
  dplyr::arrange(external_crossing_reference)
# 
# # or like this:
# 
xref_pscis_my_crossing_modelled <- rfp::rfp_bcd_get_data(
  bcdata_record_id = "WHSE_FISH.PSCIS_ASSESSMENT_SVW",
  col_filter = 'FUNDING_PROJECT_NUMBER',
  col_filter_value = 'skeena_2023_Phase1',
  col_extract = c('EXTERNAL_CROSSING_REFERENCE', 'STREAM_CROSSING_ID'),
  drop_geom = TRUE
)