Closed lucy-schick closed 7 months ago
I think it will be easier for me to review this by merging first and viewing the raw files and html outputs.
Overall - It all looks great from first glace.
A couple things i can see are:
fpr_*
namespace reserved for functions that actually come from that package (or others - ex. trfp_*
). Autocomplete is more our friend when we use it that way. for local functions that are likely to land in that package we can use tfpr_
(test) or lfpr_*
(local if you prefer). It is easy to keep track of this type of thing with just one example in the present but when we get a bunch of them, teams grow and years go by things can easily get complicated.....Awesome, just made the above changes. Let me know if theres anything else.