NewGraphEnvironment / restoration_wedzin_kwa_2024

https://newgraphenvironment.github.io/restoration_wedzin_kwa_2024
Other
0 stars 1 forks source link

Figures #34

Closed lucy-schick closed 7 months ago

lucy-schick commented 7 months ago
NewGraphEnvironment commented 7 months ago

I think it will be easier for me to review this by merging first and viewing the raw files and html outputs.

Overall - It all looks great from first glace.

A couple things i can see are:

  1. often best to keep params and even chunk names as general as possible within chunks (ex. my_caption vs caption_xyg) . This allows the work to be reused elsewhere without project specific edits to similiar chunks . There are lots of examples in our past work where this wasn't done but over time we can look to generalize to reduce pointless minor text changes
  2. lets keep the fpr_* namespace reserved for functions that actually come from that package (or others - ex. trfp_*). Autocomplete is more our friend when we use it that way. for local functions that are likely to land in that package we can use tfpr_ (test) or lfpr_* (local if you prefer). It is easy to keep track of this type of thing with just one example in the present but when we get a bunch of them, teams grow and years go by things can easily get complicated.....
lucy-schick commented 7 months ago

Awesome, just made the above changes. Let me know if theres anything else.