NewPipeX / NewPipeX

NewPipe, eXtended!
https://newpipex.org
GNU General Public License v3.0
186 stars 0 forks source link

Doesn't block sponsors when started in background #29

Open ihatemakinganaccount opened 8 months ago

ihatemakinganaccount commented 8 months ago

This has been an issue with the original fork as well, but never resolved.

Repro:

  1. Launch app from anew
  2. Choose a video that has SB segments set to skip, and not on a whitelist
  3. Play in background (either open the video without autoplay and use the Background button; or long-tap a video from a feed/playlist/channel and pick Start in background)

Result: SB segments aren't skipped Expected: SB segments should be skipped

As a workaround, one can start the video normally or in popup, and switch to background afterwards. The segments will then be skipped on all the following videos, including playlists, until the app is closed or unloaded from memory (I think).

Thanks for picking up the project btw :)

ihatemakinganaccount commented 6 months ago

@javulticat any interest in this?

The issue has actually gotten worse with newer Android. With 9 it was enough to do the workaround once per session, but with 14 it's needed every time one starts a new playlist, or whenever the app resets/refreshes in the background.

I'll also check with Tubular as that one has the problem too.