search

NewSpring / Holtzman

The main NewSpring namespace and utilities for all newspring packages.
http://holtzman.newspring.io/
Other
24 stars 10 forks source link

Updated Communications Table #1984

Closed cdanwards closed 6 years ago

cdanwards commented 6 years ago

Updated Communications Table in Holtzman to reflect changes made in Heighliner.

richarddubay commented 6 years ago

@cdanwards This looks good and I approve. Did you happen to run this locally and test to see if it sent the forgot password email? Just want to make sure that we cover all our bases. cc: @IsaacHardy

cdanwards commented 6 years ago

On Sun, Dec 17, 2017 at 9:35 AM Richard Dubay notifications@github.com wrote:

@cdanwards https://github.com/cdanwards This looks good and I approve. Did you happen to run this locally and test to see if it sent the forgot password email? Just want to make sure that we cover all our bases. cc: @IsaacHardy https://github.com/isaachardy

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NewSpring/Holtzman/pull/1984#issuecomment-352259933, or mute the thread https://github.com/notifications/unsubscribe-auth/AId5xCWUVPz8xO8jy-JSAUIvpcBU9ewtks5tBSazgaJpZM4RCpes .

Hey Rich,

I didn’t. I totally forgot to do that.

richarddubay commented 6 years ago

@cdanwards No worries! We can do that the next time you're in. It'll be good to get you set up to be able to run the app and all that. @IsaacHardy just got all that up and running, so getting him to show you how to do it would be a great refresher for him.

cdanwards commented 6 years ago

@richarddubay That sounds great to me. The more I thought about it, I realized I wasn't quite sure how those processes worked. Thanks!

richarddubay commented 6 years ago

@cdanwards I'm going to go ahead and merge this, and we'll still test it when you come in.

cdanwards commented 6 years ago

@delianides Here is the PR with all of the commits that I made to Holtzman that seem to cause the errors. Let me know if there's anything else I can point you to!