NewSpring / Rock-Plugins

NewSpring plugins for Rock RMS
http://www.rockrms.com/
3 stars 5 forks source link

Button Layouts in Rock Theme (Alpha) #205

Open FrankGrand opened 8 years ago

FrankGrand commented 8 years ago

Something is up with the button spacing: screenshot 2015-12-02 at 10 47 44 am

FrankGrand commented 8 years ago

Here is another formatting bug on Global Attributes Page: screenshot 2015-12-07 at 8 19 50 am

jbaxleyiii commented 8 years ago

@edolyne do you have an idea what is causing this? I started to look into it last week but didn't get very far

edolyne commented 8 years ago

@jbaxleyiii Yes

image

edolyne commented 8 years ago

@jbaxleyiii This issue arises from the way that we are styling .list-as-blocks, with margins varying based on children elements. This doesn't always work as expected and is causing the issue that we are seeing here. One solution would be to style these on desktop so that the style can go all the way down to mobile, without needing to worry about adjusting left and right margins at breakpoints which should be more reliable.

jbaxleyiii commented 8 years ago

Lets do that!

On Mon, Dec 7, 2015 at 10:53 AM, Edolyne Long notifications@github.com wrote:

@jbaxleyiii https://github.com/jbaxleyiii This issue arises from the way that we are styling .list-as-blocks, with margins varying based on children elements. This doesn't always work as expected and is causing the issue that we are seeing here. One solution would be to style these on desktop so that the style can go all the way down to mobile, without needing to worry about adjusting left and right margins at breakpoints which should be more reliable.

— Reply to this email directly or view it on GitHub https://github.com/NewSpring/Rock-Plugins/issues/205#issuecomment-162564830 .

James Baxley III Development Director NewSpring Church newspring.cc 803-348-3822

edolyne commented 8 years ago

I take it gremlins is not a valid response for why bugs exist?

dcs619 commented 8 years ago

@FrankGrand just fyi, we shouldn't be using this repo any more. If you find issues file them in https://github.com/NewSpring/Rock

FrankGrand commented 8 years ago

@dcs619 So are we gonna move all these issues over there?

dcs619 commented 8 years ago

I think new ones would be created at Rock and we continue to knock these out as we have margin.