Code Review

[nmontalbanocouncil]

Check for:

• readability
• getting the same results/outputs
• clear methodology

[nmontalbanocouncil]

@romartinez-nycc Overall looks good! Couldn't get some parts to run because of a csv issue, which is noted below.

code/for_carto_map/01_carto_queries.R:

• Comment out this full section and add source('code/00_load_dependencies.R') in script https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/e9e1e72172dfff7675c6e42dc0f5a4facc6d63af/code/for_carto_map/01_carto_queries.R#L4

code/dirty_sidewalk_oath/01_oath_charges.R

• is this the correct csv to read? the subsequent lines of code in the script don't work using this csv https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/e9e1e72172dfff7675c6e42dc0f5a4facc6d63af/code/dirty_sidewalk_oath/01_oath_charges.R#L39

• what do you mean first time? as in if the csv's don't already exist? would it make sense to run this script if there were new codes or if they changed? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/e9e1e72172dfff7675c6e42dc0f5a4facc6d63af/code/dirty_sidewalk_oath/01_oath_charges.R#L3

code/dirty_sidewalk_oath/02_oath_eda_cleaning.R

• couldn't run because code/dirty_sidewalk_oath/01_oath_charges.R had errors

code/dirty_sidewalk_oath/03_oath_cats_api_pull.R

• small but you don't need to rep you can just do illegal_dumping$category <- 'Illegal Dumping'
• I didn't know about skim, cool! https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/9325c2b21110b0b6711d68cdc798ad89cec54778/code/dirty_sidewalk_oath/03_oath_cats_api_pull.R#L104
• do they get dropped somewhere? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/9325c2b21110b0b6711d68cdc798ad89cec54778/code/dirty_sidewalk_oath/03_oath_cats_api_pull.R#L106
• should this section be moved to the archive folder? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/9325c2b21110b0b6711d68cdc798ad89cec54778/code/dirty_sidewalk_oath/03_oath_cats_api_pull.R#L110

code/dirty_sidewalk_oath/04_oath_summaries.R

• Works!

code/dirty_sidewalk_oath/05_oath_visuals.R

• should this section be added to archive folder? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/dirty_sidewalk_oath/05_oath_visuals.R#L78

[nmontalbanocouncil]

@rhirotacouncil everything ran and looks good! some small comments on the two scripts below

code/311_committee_requests/01_311_initial_request.Rmd

• Maybe convert this openning paragraph into a more general statement about the purpose of the doc since this will be for the public https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/01_311_initial_request.Rmd#L7
• Use source('code/00_load_dependencies.R') instead https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/01_311_initial_request.Rmd#L12
• Maybe can remove this if it is just commented out? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/01_311_initial_request.Rmd#L48
• Any reason for using one and not the other? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/01_311_initial_request.Rmd#L56
• Is the old version or new version supposed to be used? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/01_311_initial_request.Rmd#L60
• I could be missing it but is there a reason for using dsny_311 here and od_dl above? https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/01_311_initial_request.Rmd#L120

code/311_committee_requests/02_311_interactive.R

• Replace with source('code/00_load_dependencies.R') https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/02_311_interactive.R#L1
• You can use rbind(df_1, df_2, df_3, df_4) to condense the code https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/02_311_interactive.R#L68-L69
• Maybe add a link / reference to where this was pulled from so it can be replicated in the future if we forget https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/311_committee_requests/02_311_interactive.R#L62

[nmontalbanocouncil]

@fryenycc Looks good! Couldn't get a part to run because of a LIONs download issue, which is noted below, but I may just be missing something.

code/dsny_biz-complaints-violations_2023.R

• Can you put the full name instead of the acryonym the first time you use it? I'm not sure what dca is https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/dsny_biz-complaints-violations_2023.R#L32
• I didn't know this one. I'll be using it in the future https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/dsny_biz-complaints-violations_2023.R#L59
• Is this the right link? I'm not seeing it after downloading the LIONs data but could be missing it https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/dsny_biz-complaints-violations_2023.R#L157
• Consider deleting if not using https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/dsny_biz-complaints-violations_2023.R#L218

code/dsny_litter_basket_complaints.R

• add url to download since it is not on github https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/dsny_litter_basket_complaints.R#L65
• Consider deleting since not using https://github.com/NewYorkCityCouncil/street_cleanliness_sept23/blob/58cea84f293760335d7e062ee132887ec9d3e69d/code/dsny_litter_basket_complaints.R#L105

[nmontalbanocouncil]

Separate general comments:

• data/olb_over_time.csv is not in an input/output folder
• some leftover blank.txt files
• the names of the files in visuals folder (do with this comment what you please lol)