Code Review Request

[rhirotacouncil]

Code review request for Storefronts_ct_map.Rmd and Storefronts_cd_map.Rmd.

Some things:

• Storefronts_cd_map.Rmd needs to be run first.
• The census tract info was initially formatted differently between the census and the vacancy data set. The updated formatting/merged shapefile definitely needs to be checked to make sure the tracts line up correctly. I left some notes on the .Rmd about a few potential issues.

Let me know if anything is confusing!

[romartinez-nycc]

Reorganized the repo to follow the project template structure.

• As a result, your .gitignore additions were removed. I think you can add it back on your end only and don't commit & push it back into the gitignore file. It's also fine to commit the files as well. https://github.com/NewYorkCityCouncil/vacant_storefronts/blob/994d4a9dc51f81c218a0471ac593e3cba98e2277/.gitignore#L2-L18
• You can move your libraries into the 00_load_depencies.R file. https://github.com/NewYorkCityCouncil/vacant_storefronts/blob/ff67d0075566162eeb91870cb2583cb922fe9f0d/Code/Storefronts_cd_map.Rmd#L15-L29

Storefront_cd_map.rmd

No issues in running the code, I was able to run it all the way through 🎉

Code efficiency suggestions

Vroom::vroom() is a bit faster if you'd like to use it. https://github.com/NewYorkCityCouncil/vacant_storefronts/blob/ff67d0075566162eeb91870cb2583cb922fe9f0d/Code/Storefronts_cd_map.Rmd#L31

Code documentation

It's helpful to comment on how you are validating your bin choice for the variable being mapped. (There is a small typo, the column is vacant_2022.) https://github.com/NewYorkCityCouncil/vacant_storefronts/blob/ff67d0075566162eeb91870cb2583cb922fe9f0d/Code/Storefronts_cd_map.Rmd#L79-L90

• Here is a comment example from Nick: https://github.com/NewYorkCityCouncil/electrifying-transportation/blob/ecb876dc05457d67541c9d4dc10e2c6f836c2c47/code/02_car-ownership_map.R#L16
• Here is an example of how your commented-out code could work:

  
  int_cd <- classInt::classIntervals(vacant_cd.shp$vacant_2022, n = 5, style = 'jenks')

pal_cd <- colorBin( palette = nycc_pal("warm")(5), bins = int_cd$brks, domain = vacant_cd.shp$vacant_2021, na.color = "#E6E6E6", )

####  Map Improvements 

1. Legend 

Above, I used the existing council red-warm palette from the webpage, but open to discussing whether we should change it to the council blue. I don't have a preference.  For `nycc_pal("warm")(5)`, we should try to limit our bins to a max of 7, drawing from behavioral science, a legend with more than 7 can be too much for the human brain to take in.  For the census tract map, since the tracts are small, we can consider playing with a continuous range of colors (heatmap style) over one that has been divided into bins of discrete colors.

2.  No need to define the following leaflet parameters:

   - min/max zoom (were recently added to the`addCouncilStyle()` function thanks to James!)
   - setView
   - white background 
   - It's easier to leave the height & width parameters undefined at this stage. We can adjust the size within the WordPress iframe stage for the HTML output or within mapshot for the static export ex.`vwidth = 900, vheight = 870.` https://github.com/NewYorkCityCouncil/vacant_storefronts/blob/ff67d0075566162eeb91870cb2583cb922fe9f0d/Code/Storefronts_cd_map.Rmd#L99-L116

You may need to reinstall the councildown package to pull in the latest updates
`remotes::install_github("newyorkcitycouncil/councildown")`

####  Map Suggestions

1. I tend to read in datasets into leaflet, for example, the `vacant_cd.shp` dataset within the addPolygon or other addLealfet functions over including it in the main leaflet() section. This is most helpful when mapping multiple datasets, for example, if you also wanted to add boro polygons, it may lead to fewer code issues. https://github.com/NewYorkCityCouncil/vacant_storefronts/blob/ff67d0075566162eeb91870cb2583cb922fe9f0d/Code/Storefronts_cd_map.Rmd#L99
2. Running the map gave me the chance to play around with Anne's new councildown map functions like addLegend_decreasing() and the `highlight_dists =` parameter within addCouncilStyle(). I will share the jpeg of how that ended up looking.