Rose cr - Githubissues

NewYorkCityCouncil / vacant_storefronts

Analyzing vacant storefronts dataset

0 stars 0 forks source link

Rose cr #4

Closed romartinez-nycc closed 5 months ago

romartinez-nycc commented 1 year ago

I made the same initial changes across all the .rmd files in the code folder.

moved all libraries to 00_load_dependencies.R
moved all common datasets to 00_load_dependencies.R
- boro.shp
- ct.shp
- nta.shp ? (did I ?) *maybe this can stay within the nta file only?
- cd.shp *same?
- storefront dataset from open data
- I renamed all the vectors that pulled the storefront data to vacant_dataset as named in load_dependencies

romartinez-nycc commented 1 year ago

For the latest commit https://github.com/NewYorkCityCouncil/vacant_storefronts/pull/4/commits/b9a2d743b2f7418cf914f54478550c30c8d2d5d9,

I added a library I missed into load_dependencies (classInt),
made sure the .rmd files (nta, cd) had the spatial vectors renamed to how it was set in load_dependencies,
swapped some leaflet functions to the councildown version
- pal_nycc() (check if it works on your computer, the T&T made some recent fixes!)
- addCouncilStyle()
- mapshot()
- addLegendDecreasing() (let me know if you don't prefer this!)