Refactor lerax-square example: use GameLoop and InputHandler

NewayPix / hazard-memory

An experimental SDL2 Game Engine written in C++

MIT License

0 stars 0 forks source link

Closed ryukinix closed 4 years ago

ryukinix commented 4 years ago

Closes #19

CHANGELOG:

Use GameLoop instead and remove the following methods:
- constructor
- destructor
- run
Use InputHandler and simplify Game::event method

From 226 lines, now that example has only 152. We can reduce a few lines maybe using ColliderScreen too. Maybe.

ryukinix commented 4 years ago

Next week I'll merge this. Feel free to review. @wesleycsj @rafaelcn

wesleycsj commented 4 years ago

Everything seems default and ok for me.

ryukinix commented 4 years ago

Can someone approve that PR? @rafaelcn @wesleycsj

wesleycsj commented 4 years ago

Merging blocked for me. You should resolve rafnu request changes first.

ryukinix commented 4 years ago

I'm request to approve via code review, not merge it @wesleycsj. I mean:

Files Changed > Review Changes > Approve > Submit Review

I will not merge now because I need to rebase against master branch.