search

Newbrict / ObjHunt

A Good Garry's Mod Prop Hunt
Apache License 2.0
17 stars 21 forks source link

Read Description #19

Closed jtsalisbury closed 10 years ago

jtsalisbury commented 10 years ago
jtsalisbury commented 10 years ago

I can't see how. 1 == true and 0 == false. Which has no reason not to work.

jtsalisbury commented 10 years ago

I changed it to tobool(var) for you, even though I have no doubt it would have worked.

Newbrict commented 10 years ago

I'm going to have to test it before I merge I had tried something with tobool prior to it's current state and it did not work however I'm certain the first part would not have worked because of how the WriteBit works

It looks at the definition not evaluation of the input, so 0 is defined, and therefore true.

jtsalisbury commented 10 years ago

Did more tests. tobool() works, however 0 in any if statement seemed to return false? Which is gay as fuck, and totally stupid. However I reverted the things that would be affected by it.

jtsalisbury commented 10 years ago

Sorry about that :-1:

NEWBRICT: I had the same thought process, believe me.... I spent forever trying to determine the problem, lo and behold the broken net library

jtsalisbury commented 10 years ago

The first reply was a local variable that just sits there. You aren't sending it anywhere. The second one wouldn't matter because you're just rewriting the bit.

jtsalisbury commented 10 years ago

There's a reason I don't use bits. Lmao

jtsalisbury commented 10 years ago

Close this since there are conflicts now..

Newbrict commented 10 years ago

Alright, If you want to make another pull request with the local vars and the code cleanup feel free, otherwise I'll just copy them from your commits later tonight

thanks!