NewcastleRSE / dolfin-flutter

The Flutter-based app for the Dolfin Project
0 stars 0 forks source link

Tweaks and Bug Fixes from Madeline's email (25/07) #86

Closed mdsimpson42 closed 2 years ago

mdsimpson42 commented 2 years ago
mdsimpson42 commented 2 years ago

Need to test "tapping on the tile" on a device. Was working in Emulator but not on phone.

KateCourt commented 2 years ago

Don't address:

  1. When I am logging in/signing up, the keyboard hides password field and the screen doesn't move "up" to allow me to see it explain that this is unavoidable

  2. There is no warning message if scoops of supplement too low compared to weight (e.g. I put 4.07 kg and 1 scoop). I'm not sure that we discussed this as functionality. Would it be possible to add some sort of message like "The number of scoops of supplement you are given doesn't seem to match the weight you provided. Please check the DOLFIN supplement chart from your parent discharge pack"? I can confirm correct number of scoops per weight if so we cannot provide clinical advice within the app

  3. I found it a bit unclear whether the "Back" button in the Help section takes you out of the section, or just back to the previous screen of it I suggest leaving as it is - the begin button serves to take you out of the help section?

  4. Only being able to edit/view the supplement doses by tapping the pen icon feels a bit counterintuitive to me, I'd expect tapping on the tiles to do something - but this isn't a big deal suggest leaving as pen icon is fairly universal editing symbol? (already fixed - see above)

Discuss between us:

  1. I am not sure that we want the parent to have the option to confirm whether baby was pre- or post-discharge recruit, or supplying EDD or DOB - I think we should hold this information already so it would be better if it is sourced via our API (if this is possible) discuss before response - getting from API is OK, but we'd need to also prevent this information being editable later on, maybe 1-2days work?
  2. In general, the option is given to type in the date rather than select on the calendar, but there's no "/" key on the supplied keyboard to actually do it this it true - @mdsimpson42 what do you think about just removing the pen option - or can we change to use a full keyboard?
  3. In general, it seems like I can't select dates before 2022, or in actual fact beyond a week from the day I was accessing the app. This isn't desirable when entering date of weight, which could be earlier (or DOB or EDD, if we keep these in as editable fields) I can see why we might not need 2021, but are we able to allow users to go to previous months?
  4. The icons to navigate to the different sections are a nice design but I didn't find it intuitive what they meant. Would it be possible to give them titles as well, or include what they mean in the Help section? add to help section
  5. The Help section states you can view previous weights, but this doesn't seem to be the case I'm guessing this was left from when weight was part of the daily forms - we could just remove the reference from the help section?
  6. Could we have a "thank you for submitting a weight for your baby" message appearing when you submit, rather than it just going back to the main screen?
  7. If you say "Yes" to the unplanned hospital admission, nothing else happens: there should probably be a pop-up saying "Thank you for letting us know. A member of your local clinical team will be in touch to ask you about this"
mdsimpson42 commented 2 years ago
  1. In android (emulator and my phone) I don't get any keyboard option, only the calendar. Is this an iOS thing? Maybe we can force it to be calendar only?

  2. I don't think I impose any limit based on the number of weeks. I think I may have set 1st Jan 2022 as a field on some of them, I can set an earlier date if necessary (but how far back are we going to go, realistically?)

  3. I think we have gone for the most sensible symbols from the ones available. I will change the images in the help section to explain what each button does.

  4. Yes, it was placeholder text thrown together at the start of the project. The images are not relevant either but are left over from the TODO app. They should probably specify the copy for these pages (and we can update the images to make them more relevant). Otherwise, I would leave this section alone (unless they want more pages added, which should be relatively easy).

  5. (+11.) There currently isn't a way to just pop up a message like this, as far as I am aware. It would be relatively easy to implement and use the same functionality for both pages. The easiest implementation would be to assume that it works and just say "thank you", rather than actually waiting/checking whether the upload has been successful?

mdsimpson42 commented 2 years ago

Have added "Thank you" pop-ups to address issues 10 & 11 (plus two other places where data is submitted)

mdsimpson42 commented 2 years ago

RE 6 - The problem is that the input is a "MyTextfield" object, which brings up the date picker when you click on it. We should probably replace it with a proper date field, there seem to be a few relevant packages. However, I think the quickest solution would be to change the keyboard type to "none". That should prevent the keyboard from coming up all together, but will still allow input from the date picker. Will need to test this on IOS (it doesn't happen on Android) to confirm that this has fixed it.

mdsimpson42 commented 2 years ago

Closing as unresolved points are addressed in separate issues