Closed mdsimpson42 closed 2 years ago
Need to test "tapping on the tile" on a device. Was working in Emulator but not on phone.
Don't address:
When I am logging in/signing up, the keyboard hides password field and the screen doesn't move "up" to allow me to see it explain that this is unavoidable
There is no warning message if scoops of supplement too low compared to weight (e.g. I put 4.07 kg and 1 scoop). I'm not sure that we discussed this as functionality. Would it be possible to add some sort of message like "The number of scoops of supplement you are given doesn't seem to match the weight you provided. Please check the DOLFIN supplement chart from your parent discharge pack"? I can confirm correct number of scoops per weight if so we cannot provide clinical advice within the app
I found it a bit unclear whether the "Back" button in the Help section takes you out of the section, or just back to the previous screen of it I suggest leaving as it is - the begin button serves to take you out of the help section?
Only being able to edit/view the supplement doses by tapping the pen icon feels a bit counterintuitive to me, I'd expect tapping on the tiles to do something - but this isn't a big deal suggest leaving as pen icon is fairly universal editing symbol? (already fixed - see above)
Discuss between us:
In android (emulator and my phone) I don't get any keyboard option, only the calendar. Is this an iOS thing? Maybe we can force it to be calendar only?
I don't think I impose any limit based on the number of weeks. I think I may have set 1st Jan 2022 as a field on some of them, I can set an earlier date if necessary (but how far back are we going to go, realistically?)
I think we have gone for the most sensible symbols from the ones available. I will change the images in the help section to explain what each button does.
Yes, it was placeholder text thrown together at the start of the project. The images are not relevant either but are left over from the TODO app. They should probably specify the copy for these pages (and we can update the images to make them more relevant). Otherwise, I would leave this section alone (unless they want more pages added, which should be relatively easy).
(+11.) There currently isn't a way to just pop up a message like this, as far as I am aware. It would be relatively easy to implement and use the same functionality for both pages. The easiest implementation would be to assume that it works and just say "thank you", rather than actually waiting/checking whether the upload has been successful?
Have added "Thank you" pop-ups to address issues 10 & 11 (plus two other places where data is submitted)
RE 6 - The problem is that the input is a "MyTextfield" object, which brings up the date picker when you click on it. We should probably replace it with a proper date field, there seem to be a few relevant packages. However, I think the quickest solution would be to change the keyboard type to "none". That should prevent the keyboard from coming up all together, but will still allow input from the date picker. Will need to test this on IOS (it doesn't happen on Android) to confirm that this has fixed it.
Closing as unresolved points are addressed in separate issues