Newcomer1989 / TSN-Ranksystem

A PHP Bot that assigns time based server groups on TeamSpeak3.
https://ts-ranksystem.com
GNU General Public License v3.0
144 stars 60 forks source link

Install.php - Drop Database ? #101

Closed Zignixx closed 8 years ago

Zignixx commented 8 years ago

Maybe it would be good if you remove the drop database OR show a warning if you install it. Because of this "Drop Database", i lost my whole database. Why is it needed? Use a tsranking_ prefix or show at least a warning.

Newcomer1989 commented 8 years ago

You want to clearly install the Ranksystem, it's important to be sure, there is no database or rest of a database. That is why it gets dropped at first.

In your case I think, you want to update the database. Then the install.php is the wrong way.

What you thought will happen, if you start to install the Rankystem and input an already existing database?

Zignixx commented 8 years ago

Well i used a database on our server which is for all the clan stuff. What i thought will happen? Install it over install.php without a drop. Other webinterfaces / cms / forums can do this without a drop (custom table names as example).

Newcomer1989 commented 8 years ago

Built for release 1.1.1: There will come a warning message due instllation, if the database is already exisiting.

ATTENTION: You are trying to install the Ranksystem, but there is already existing a database with the name \"DB-Name\". Due installation this database will be dropped! Be sure you want this. If not, please choose an other database name.