search

NewtonKoh / pe

0 stars 0 forks source link

Accepts invalid timing as valid #1

Open NewtonKoh opened 6 months ago

NewtonKoh commented 6 months ago

image.png

When I input st/2400 and et/2300, the command validates this timing by treating 2400 as 0000 of the same day instead of the next day. Which seems to be incorrect, since 2400 is clearly larger than 2300.

I'm not very sure if this is considered medium or low severity. Might be medium?

nus-pe-bot commented 5 months ago

Team's Response

Thanks for the report, we've identified it as a duplicate of another bug

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect Error Message

image.png

As seen in the image, the end time is clearly larger than the start time, but the error message indicates that the end time should be larger than the start time? I believe the Error Message should be that the end time is invalid or something in that regard.

[original: nus-cs2103-AY2324S2/pe-interim#5247] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the feedback!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Thank you for accepting this bug report. I was actually also the one who reported the bug that you marked as duplicate! I believe that they are separate issues although I do understand that the root cause of the issue is the same (time parsing). However, I believe that not having a correct error message to indicate the user's input error and accepting the user's invalid input should not be considered the same bug.