#134: Belos: Add TFQMR tpetra test

NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project

https://trilinos.org/

Other

0 stars 2 forks source link

#134: Belos: Add TFQMR tpetra test #135

Closed antoinemeyer5 closed 1 year ago

antoinemeyer5 commented 1 year ago

Fixes #134

This PR converts the following tests:

[x] test_tfqmr_diag.cpp
[x] test_tfqmr_hb.cpp (in test_tfqmr_hb.cpp with parameter not-pseudo)
[x] test_pseudo_tfqmr_hb.cpp (in test_tfqmr_hb.cpp with parameter pseudo)

Note: currently, the following tests cannot be converted due to their use of a preconditioner (the original examples use Ifpack; however, including IfPack2 creates a circular dependency with Belos)

test_ptfqmr_hb
test_pseudo_ptfqmr_hb

cwschilly commented 1 year ago

@antoinemeyer5 One other note is that my PR to Trilinos failed due to the -Werror pipeline--I recommend making sure no warnings are being introduced before you put it up to the main repo

antoinemeyer5 commented 1 year ago

@antoinemeyer5 One other note is that my PR to Trilinos failed due to the -Werror pipeline--I recommend making sure no warnings are being introduced before you put it up to the main repo

Hey @cwschilly thanks for the review! When you talked about warnings, you mean we should not add new warnings, right? Because there are already warnings and tests that don't pass in pieces of code that we have never touched. Can you confirm to me that the way to check that the CI has been carried out correctly is to go to "Details" and then "Summary"? I still have 8 failed tests (2 StratimikosGaleri[...], 4 Zoltan_2 and more) but as you can see it's not because of my new code. Thank you in advance for you time to answer me

cwschilly commented 1 year ago

@antoinemeyer5 One other note is that my PR to Trilinos failed due to the -Werror pipeline--I recommend making sure no warnings are being introduced before you put it up to the main repo

Hey @cwschilly thanks for the review! When you talked about warnings, you mean we should not add new warnings, right? Because there are already warnings and tests that don't pass in pieces of code that we have never touched. Can you confirm to me that the way to check that the CI has been carried out correctly is to go to "Details" and then "Summary"? I still have 8 failed tests (2 StratimikosGaleri[...], 4 Zoltan_2 and more) but as you can see it's not because of my new code. Thank you in advance for you time to answer me

Yes exactly, just make sure you're not adding new warnings. I think this is good to go