NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
0 stars 2 forks source link

#163: Belos: Provide `Tpetra` version of LSQR examples #168

Closed tlamonthezie closed 1 year ago

tlamonthezie commented 1 year ago

Fixes #163

PR to Trilinos: https://github.com/trilinos/Trilinos/pull/12300

tlamonthezie commented 1 year ago

Hello @stmcgovern

The new PrecLSQRTpetraExFile example would require to add ifpack2 as dependency for Belos but it would add a circular dependency. It is due to the fact that in Ifpack2 depnds on Belos (only for some tests and examples as I can see)

I think there are 2 possibilities if we want to have a new Tpetra version of this example:

I think the option A is easier to apply but the option B might be more logic even if we have to modify 2 packages at once. @stmcgovern could you please give me some guidance on that or ask Belos and Ifpack2 package owners ? Or is there maybe a place where to add tests and examples external to thse 2 packages to prevent the circular dependency ?

As I am writing this comment I am working on making the example working by ignoring the dependency problem but we will have to know how to make it work at build stage to not have dependency issue.

tlamonthezie commented 1 year ago

Currently the example does not complete before test timeout of 1500 seconds in the CI if we include the example as a test. But it WORKS on local machine in one second. So I guess the problem is not the code but might be the parameters or someting linked to the CI machine... I suggest to ignore that timeout.