search

NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
0 stars 2 forks source link

#181: Belos: Add GCRODR tpetra tests #182

Closed antoinemeyer5 closed 1 year ago

antoinemeyer5 commented 1 year ago

Fix #181

This PR updates the following tests:

Note: currently, the following test cannot be converted due to its use of Ifpack (the original examples use Ifpack; however, including IfPack2 creates a circular dependency with Belos)

github-actions[bot] commented 1 year ago

:zap: Code quality check :zap:

:red_circle: clang-tidy found 9 issues! Click here to see details.
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L63-L68 ```diff !Line: 63 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L63-L68 ```diff !Line: 63 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L63-L68 ```diff !Line: 63 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L80-L85 ```diff !Line: 80 - warning: variable 'mpisess' of type 'Teuchos::GlobalMPISession' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L126-L131 ```diff !Line: 126 - warning: variable 'reader' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L127-L132 ```diff !Line: 127 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L127-L132 ```diff !Line: 127 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L222-L226 ```diff !Line: 222 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/5f840265399a4937801fbc110f42e4f12aa16962/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L222-L226 ```diff !Line: 222 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```