search

NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
0 stars 2 forks source link

#180: Belos: Provide `Tpetra` version of TFQMR examples #183

Closed tlamonthezie closed 1 year ago

tlamonthezie commented 1 year ago

Fixes #180

PR to Trilinos: https://github.com/trilinos/Trilinos/pull/12327

Currently these examples cannot build inside Trilinos (Commented in CmakeLists.txt) because of a circular dependency

Circular Dependency to Ifpack2 has to be fixed first The 2 examples can only be compiled when adding Ifpack2 as a dependency of Belos (like Ifpack) and by disabling dependencies from ifpack2 to Belos because there is a circular dependency between these 2 packages to fix first. So it should work after dependency fix.

Possible Obsolete HB Matrix File Reader This example shows also how to use the Tpetra::Utils:readHBMatrix which does not require TriUtil (epetra does require it) The fact is that Tpetra fail to open orsirr1.hb file found in the epetra tests and this data file is very old so it might be obsolete for now ? (there is no HB version option found in Tpetra::Utils:readHBMatrix it just complains about an invalid file format)

To see the problem you can change the following (using the TriUtil HB reader)

Belos::Tpetra::HarwellBoeingReader<Tpetra::CrsMatrix<ST> > reader( comm );
RCP<Tpetra::CrsMatrix<ST> > A = reader.readFromFile( filename );
RCP<const Tpetra::Map<> > map = A->getRowMap();

to that (Tpetra Utils HB reader)

RCP<MAT> A;
Tpetra::Utils::readHBMatrix(filename, comm, A);
RCP<const MAP> map = A->getRowMap();`

It does not work with osrirr1.hb but works like it has been done here with another .hb data file found in trilinos

jwillenbring commented 1 year ago

Heidi provided the following response: The Tpetra HB matrix reader needs to be fixed then. This is a common format for matrices to be stored in and not being able to read them in for examples and tests is a problem for the solver packages. Not fixing the reader will just be postponing the inevitable.

I think this means this goes into the problem area for now.

tlamonthezie commented 1 year ago

Finally a new version of orsiss.hb has been found and is working with the Tpetra::Utils::readHBMatrix method and will be part of this PR

github-actions[bot] commented 1 year ago

:zap: Code quality check :zap:

:red_circle: clang-tidy found 74 issues! Click here to see details.
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L75-L80 ```diff !Line: 75 - warning: function 'run' has cognitive complexity of 45 (threshold 25) [readability-function-cognitive-complexity] !Line: 115 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 127 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 130 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 134 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 138 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 141 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 144 - note: +1 !Line: 184 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 189 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 191 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 193 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 195 - note: +1, nesting level increased to 1 !Line: 210 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 211 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 220 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 230 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 234 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 247 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 249 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 252 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 257 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 257 - note: +1 !Line: 259 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 261 - note: +1, nesting level increased to 1 !Line: 263 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 267 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 267 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 267 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 267 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 267 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 267 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 267 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 269 - note: +1, including nesting penalty of 0, nesting level increased to 1 ``` https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L75-L80 ```diff !Line: 75 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L100-L105 ```diff !Line: 100 - warning: variable 'session' of type 'Teuchos::GlobalMPISession' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L100-L105 ```diff !Line: 100 - warning: use nullptr [modernize-use-nullptr] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L113-L118 ```diff !Line: 113 - warning: variable 'tol' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L115-L120 ```diff !Line: 115 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L118-L123 ```diff !Line: 118 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L121-L126 ```diff !Line: 121 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L122-L127 ```diff !Line: 122 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L124-L129 ```diff !Line: 124 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L125-L130 ```diff !Line: 125 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L127-L132 ```diff !Line: 127 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L130-L135 ```diff !Line: 130 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L134-L139 ```diff !Line: 134 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L136-L141 ```diff !Line: 136 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L136-L141 ```diff !Line: 136 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L138-L143 ```diff !Line: 138 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L140-L145 ```diff !Line: 140 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L141-L146 ```diff !Line: 141 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L184-L189 ```diff !Line: 184 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L189-L194 ```diff !Line: 189 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L193-L198 ```diff !Line: 193 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L195-L200 ```diff !Line: 195 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L199-L204 ```diff !Line: 199 - warning: variable 'X' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L199-L204 ```diff !Line: 199 - warning: variable name 'X' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L201-L206 ```diff !Line: 201 - warning: variable 'B' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L201-L206 ```diff !Line: 201 - warning: variable name 'B' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L203-L208 ```diff !Line: 203 - warning: variable 'problem' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L210-L215 ```diff !Line: 210 - warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L211-L216 ```diff !Line: 211 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L217-L222 ```diff !Line: 217 - warning: variable 'solver' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L240-L245 ```diff !Line: 240 - warning: variable 'actualResids' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L241-L246 ```diff !Line: 241 - warning: variable 'rhsNorm' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L242-L247 ```diff !Line: 242 - warning: variable 'resids' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L249-L254 ```diff !Line: 249 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L250-L255 ```diff !Line: 250 - warning: variable 'actRes' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L252-L257 ```diff !Line: 252 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L259-L264 ```diff !Line: 259 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/TFQMRTpetraExFile.cpp#L263-L268 ```diff !Line: 263 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L76-L81 ```diff !Line: 76 - warning: function 'run' has cognitive complexity of 39 (threshold 25) [readability-function-cognitive-complexity] !Line: 125 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 128 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 135 - note: +1 !Line: 170 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 174 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 176 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 178 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 179 - note: +1, nesting level increased to 1 !Line: 195 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 196 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 205 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 226 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 228 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 231 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 235 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 235 - note: +1 !Line: 237 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 238 - note: +1, nesting level increased to 1 !Line: 240 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 243 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 243 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 243 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 243 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 243 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 243 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 243 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 245 - note: +1, including nesting penalty of 0, nesting level increased to 1 ``` https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L76-L81 ```diff !Line: 76 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L101-L106 ```diff !Line: 101 - warning: variable 'session' of type 'Teuchos::GlobalMPISession' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L101-L106 ```diff !Line: 101 - warning: use nullptr [modernize-use-nullptr] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L114-L119 ```diff !Line: 114 - warning: variable 'tol' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L116-L121 ```diff !Line: 116 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L119-L124 ```diff !Line: 119 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L120-L125 ```diff !Line: 120 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L122-L127 ```diff !Line: 122 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L123-L128 ```diff !Line: 123 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L125-L130 ```diff !Line: 125 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L128-L133 ```diff !Line: 128 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L131-L136 ```diff !Line: 131 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L131-L136 ```diff !Line: 131 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L133-L138 ```diff !Line: 133 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L170-L175 ```diff !Line: 170 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L174-L179 ```diff !Line: 174 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L178-L183 ```diff !Line: 178 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L179-L184 ```diff !Line: 179 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L183-L188 ```diff !Line: 183 - warning: variable 'X' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L183-L188 ```diff !Line: 183 - warning: variable name 'X' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L185-L190 ```diff !Line: 185 - warning: variable 'B' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L185-L190 ```diff !Line: 185 - warning: variable name 'B' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L188-L193 ```diff !Line: 188 - warning: variable 'problem' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L195-L200 ```diff !Line: 195 - warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L196-L201 ```diff !Line: 196 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L202-L207 ```diff !Line: 202 - warning: variable 'solver' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L219-L224 ```diff !Line: 219 - warning: variable 'actualResids' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L220-L225 ```diff !Line: 220 - warning: variable 'rhsNorm' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L221-L226 ```diff !Line: 221 - warning: variable 'resid' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L228-L233 ```diff !Line: 228 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L229-L234 ```diff !Line: 229 - warning: variable 'actRes' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L231-L236 ```diff !Line: 231 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L237-L242 ```diff !Line: 237 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/b368b716283900d9b6b5d2c7b55b4018a58828f5/packages/belos/tpetra/example/TFQMR/PseudoBlockTFQMRTpetraExFile.cpp#L240-L245 ```diff !Line: 240 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```