#190: NOX: Provide `Tpetra` versions of Brusselator tests

[antoinemeyer5]

Fixes #194

Work done:

• Addition of all the files (from .C and .H to .hpp)
• Use Tpetra instead of Epetra
• Class are now generic (template)

Work information:

• The code build
• The tests are run and 1 has failed (26 - NOX_Tpetra_brusselator_MPI_4) because the regular expression is commented out.

Work in progress:

• In Example.cpp, finish to uncomment code and do the conversion
• Fix issues (see below)

Current issues:

• There is no Tpetra equivalent for NOX::Epetra::Interface::Required:: and more NOX namespaces

[github-actions[bot]]

:zap: Code quality check :zap:

---

:red_circle: clang-tidy found 35 issues! Click here to see details.

https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L90-L95 ```diff !Line: 90 - warning: #includes are not sorted properly [llvm-include-order] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L94-L99 ```diff !Line: 94 - warning: #includes are not sorted properly [llvm-include-order] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L98-L103 ```diff !Line: 98 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L98-L103 ```diff !Line: 98 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L98-L103 ```diff !Line: 98 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L110-L115 ```diff !Line: 110 - warning: variable 'mpiSession' of type 'Teuchos::GlobalMPISession' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L122-L127 ```diff !Line: 122 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L123-L128 ```diff !Line: 123 - warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L123-L128 ```diff !Line: 123 - warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L123-L128 ```diff !Line: 123 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L127-L132 ```diff !Line: 127 - warning: variable 'NumGlobalNodes' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L127-L132 ```diff !Line: 127 - warning: 1001 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L132-L137 ```diff !Line: 132 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L132-L137 ```diff !Line: 132 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L133-L138 ```diff !Line: 133 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L133-L138 ```diff !Line: 133 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L134-L139 ```diff !Line: 134 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L135-L140 ```diff !Line: 135 - warning: function is not thread safe [concurrency-mt-unsafe] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L141-L146 ```diff !Line: 141 - warning: variable 'OType' of type 'OverlapType' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L142-L147 ```diff !Line: 142 - warning: variable 'Problem' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L145-L150 ```diff !Line: 145 - warning: variable 'soln' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L152-L157 ```diff !Line: 152 - warning: variable 'nlParams' of type 'ParameterList &' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L152-L157 ```diff !Line: 152 - warning: redundant get() call on smart pointer [readability-redundant-smartptr-get] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L172-L177 ```diff !Line: 172 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L191-L196 ```diff !Line: 191 - warning: 800 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L192-L197 ```diff !Line: 192 - warning: 1e-4 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L197-L202 ```diff !Line: 197 - warning: variable 'interface' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L379-L384 ```diff !Line: 379 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L380-L385 ```diff !Line: 380 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L381-L386 ```diff !Line: 381 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L382-L387 ```diff !Line: 382 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L384-L389 ```diff !Line: 384 - warning: 'getRank' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L384-L389 ```diff !Line: 384 - warning: 'operator<<' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L390-L393 ```diff !Line: 390 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/d9c2e9f08bf6f75dd3118915cff0340d72b57079/packages/nox/test/tpetra/Brusselator/Example.cpp#L390-L393 ```diff !Line: 390 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```