search

NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
0 stars 2 forks source link

#205: Belos: clean MINRES Tpetra test_minres_diag test #206

Closed tlamonthezie closed 1 year ago

tlamonthezie commented 1 year ago

Fixes #205

PR to Trilinos: https://github.com/trilinos/Trilinos/pull/12322 (including #70, #177, #206)

This solves also other problems related to the test_minres_diag Tpetra test

This PR comes in addition to #70 and #177 to include the Belos Tpetra MINRES tests into Trilinos.

This PR provides the following to the test_minres_diag Tpetra test in Belos:

github-actions[bot] commented 1 year ago

:zap: Code quality check :zap:

:red_circle: clang-tidy found 89 issues! Click here to see details.
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_hb.cpp#L132-L137 ```diff !Line: 132 - warning: variable 'B' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_hb.cpp#L132-L137 ```diff !Line: 132 - warning: variable name 'B' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L64-L69 ```diff !Line: 64 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L65-L70 ```diff !Line: 65 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L70-L75 ```diff !Line: 70 - warning: class 'VectorOperator' defines a non-default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,hicpp-special-member-functions] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L70-L75 ```diff !Line: 70 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L74-L79 ```diff !Line: 74 - warning: use '= default' to define a trivial destructor [hicpp-use-equals-default,modernize-use-equals-default] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L85-L90 ```diff !Line: 85 - warning: all parameters should be named in a function [hicpp-named-parameter,readability-named-parameter] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L86-L91 ```diff !Line: 86 - warning: operator=() does not handle self-assignment properly [cert-oop54-cpp] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L86-L91 ```diff !Line: 86 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L86-L91 ```diff !Line: 86 - warning: all parameters should be named in a function [hicpp-named-parameter,readability-named-parameter] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L92-L97 ```diff !Line: 92 - warning: class 'DiagonalOperator' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,hicpp-special-member-functions] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L92-L97 ```diff !Line: 92 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L96-L101 ```diff !Line: 96 - warning: use '= default' to define a trivial destructor [hicpp-use-equals-default,modernize-use-equals-default] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L98-L103 ```diff !Line: 98 - warning: overloading 'operator()' is disallowed [fuchsia-overloaded-operator] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L98-L103 ```diff !Line: 98 - warning: parameter name 'x' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L98-L103 ```diff !Line: 98 - warning: parameter name 'y' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L107-L112 ```diff !Line: 107 - warning: class 'DiagonalOperator2' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,hicpp-special-member-functions] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L107-L112 ```diff !Line: 107 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L109-L114 ```diff !Line: 109 - warning: 2 adjacent parameters of 'DiagonalOperator2' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters] !Line: 109 - note: the first parameter in the range is 'n_in' !Line: 109 - note: the last parameter in the range is 'min_gid_in' ``` https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L112-L117 ```diff !Line: 112 - warning: use '= default' to define a trivial destructor [hicpp-use-equals-default,modernize-use-equals-default] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L114-L119 ```diff !Line: 114 - warning: overloading 'operator()' is disallowed [fuchsia-overloaded-operator] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L114-L119 ```diff !Line: 114 - warning: parameter name 'x' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L114-L119 ```diff !Line: 114 - warning: parameter name 'y' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L119-L124 ```diff !Line: 119 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L133-L138 ```diff !Line: 133 - warning: class 'ComposedOperator' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,hicpp-special-member-functions] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L133-L138 ```diff !Line: 133 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L137-L142 ```diff !Line: 137 - warning: use '= default' to define a trivial destructor [hicpp-use-equals-default,modernize-use-equals-default] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L147-L152 ```diff !Line: 147 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L147-L152 ```diff !Line: 147 - warning: 2 adjacent parameters of 'ComposedOperator' of similar type ('const RCP> &') are easily swapped by mistake [bugprone-easily-swappable-parameters] !Line: 147 - note: the first parameter in the range is 'pA_in' !Line: 148 - note: the last parameter in the range is 'pB_in' ``` https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L152-L157 ```diff !Line: 152 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L152-L157 ```diff !Line: 152 - warning: parameter name 'x' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L152-L157 ```diff !Line: 152 - warning: parameter name 'y' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L161-L166 ```diff !Line: 161 - warning: class 'TrilinosInterface' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,hicpp-special-member-functions] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L161-L166 ```diff !Line: 161 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L167-L172 ```diff !Line: 167 - warning: default arguments on virtual or override methods are prohibited [google-default-arguments] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L167-L172 ```diff !Line: 167 - warning: parameter name 'X' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L167-L172 ```diff !Line: 167 - warning: parameter name 'Y' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L167-L172 ```diff !Line: 167 - warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments-declarations] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L167-L172 ```diff !Line: 167 - warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments-declarations] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L170-L175 ```diff !Line: 170 - warning: use '= default' to define a trivial destructor [hicpp-use-equals-default,modernize-use-equals-default] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L174-L179 ```diff !Line: 174 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L175-L180 ```diff !Line: 175 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: default arguments on virtual or override methods are prohibited [google-default-arguments] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: parameter name 'X' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: parameter name 'Y' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: parameter 'mode' is unused [misc-unused-parameters] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: 2 adjacent parameters of 'apply' of similar type ('ST') are easily swapped by mistake [bugprone-easily-swappable-parameters] !Line: 186 - note: the first parameter in the range is 'alpha' !Line: 186 - note: the last parameter in the range is 'beta' ``` https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: parameter 'alpha' is unused [misc-unused-parameters] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L186-L191 ```diff !Line: 186 - warning: parameter 'beta' is unused [misc-unused-parameters] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L193-L198 ```diff !Line: 193 - warning: class 'IterativeInverseOperator' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions,hicpp-special-member-functions] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L193-L198 ```diff !Line: 193 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L198-L203 ```diff !Line: 198 - warning: use '= default' to define a trivial destructor [hicpp-use-equals-default,modernize-use-equals-default] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L218-L223 ```diff !Line: 218 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L218-L223 ```diff !Line: 218 - warning: 2 adjacent parameters of 'IterativeInverseOperator' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters] !Line: 218 - note: the first parameter in the range is 'n_in' !Line: 218 - note: the last parameter in the range is 'blocksize' ``` https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L218-L223 ```diff !Line: 218 - warning: parameter 'blocksize' is unused [misc-unused-parameters] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L224-L229 ```diff !Line: 224 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L233-L238 ```diff !Line: 233 - warning: 'pProb' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L251-L256 ```diff !Line: 251 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L251-L256 ```diff !Line: 251 - warning: parameter name 'b' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L251-L256 ```diff !Line: 251 - warning: parameter name 'x' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L269-L274 ```diff !Line: 269 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L309-L314 ```diff !Line: 309 - warning: variable 'D2' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L309-L314 ```diff !Line: 309 - warning: variable name 'D2' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L310-L315 ```diff !Line: 310 - warning: variable 'A2' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L310-L315 ```diff !Line: 310 - warning: variable name 'A2' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L321-L326 ```diff !Line: 321 - warning: variable 'D' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L321-L326 ```diff !Line: 321 - warning: variable name 'D' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L322-L327 ```diff !Line: 322 - warning: variable 'Inner' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L326-L331 ```diff !Line: 326 - warning: variable 'B' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L326-L331 ```diff !Line: 326 - warning: variable name 'B' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L327-L332 ```diff !Line: 327 - warning: variable 'C' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L327-L332 ```diff !Line: 327 - warning: variable name 'C' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L330-L335 ```diff !Line: 330 - warning: variable 'Outer' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L377-L380 ```diff !Line: 377 - warning: declaration must be declared within the '__llvm_libc' namespace [llvmlibc-implementation-in-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_diag.cpp#L377-L380 ```diff !Line: 377 - warning: use a trailing return type for this function [modernize-use-trailing-return-type] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L146-L151 ```diff !Line: 146 - warning: variable 'X_exact' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L150-L155 ```diff !Line: 150 - warning: variable 'B' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L150-L155 ```diff !Line: 150 - warning: variable name 'B' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L154-L159 ```diff !Line: 154 - warning: variable 'X' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L154-L159 ```diff !Line: 154 - warning: variable name 'X' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L257-L262 ```diff !Line: 257 - warning: variable 'actualResids' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L258-L263 ```diff !Line: 258 - warning: variable 'rhsNorm' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_minres_indefinite.cpp#L259-L264 ```diff !Line: 259 - warning: variable 'resid' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_pminres_hb.cpp#L130-L135 ```diff !Line: 130 - warning: variable 'X' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_pminres_hb.cpp#L130-L135 ```diff !Line: 130 - warning: variable name 'X' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_pminres_hb.cpp#L216-L221 ```diff !Line: 216 - warning: variable 'actualResids' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/30a1938e7d58c402b0f3e508c1556e7b27f3609d/packages/belos/tpetra/test/MINRES/test_pminres_hb.cpp#L217-L222 ```diff !Line: 217 - warning: variable 'rhsNorm' is not initialized [cppcoreguidelines-init-variables] ```