#208: ShyLU: Add Tpetra tests

[cwschilly]

Fixes #208

Creates the following tests:

• shylu_factor_test_tpetra.cpp
• shylu_belos_driver_tpetra.cpp

[github-actions[bot]]

:zap: Code quality check :zap:

:red_circle: cppcheck found 29 issues! Click here to see details.

https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L24-L29 ```diff !Line: 24 - information: Include file: "Teuchos_RCP.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L25-L30 ```diff !Line: 25 - information: Include file: "Teuchos_GlobalMPISession.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L26-L31 ```diff !Line: 26 - information: Include file: "Teuchos_XMLParameterListHelpers.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L37-L42 ```diff !Line: 37 - information: Include file: "shylu.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L38-L43 ```diff !Line: 38 - information: Include file: "shylu_util.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L39-L44 ```diff !Line: 39 - information: Include file: "ShyLU_DDCore_config.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L40-L45 ```diff !Line: 40 - information: Include file: "shylu_partition_interface.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L41-L46 ```diff !Line: 41 - information: Include file: "shylu_directsolver_interface.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L459-L464 ```diff !Line: 459 - error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L500-L505 ```diff !Line: 500 - style: The scope of the variable 'tempnewvec' can be reduced. [variableScope] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L501-L506 ```diff !Line: 501 - style: The scope of the variable 'tempvec' can be reduced. [variableScope] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L296-L301 ```diff !Line: 296 - style: Variable 'success' is assigned a value that is never used. [unreadVariable] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp#L501-L506 ```diff !Line: 501 - style: Variable 'tempvec' is assigned a value that is never used. [unreadVariable] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L16-L21 ```diff !Line: 16 - information: Include file: "Isorropia_config.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L28-L33 ```diff !Line: 28 - information: Include file: "Teuchos_GlobalMPISession.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L29-L34 ```diff !Line: 29 - information: Include file: "Teuchos_XMLParameterListHelpers.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L37-L42 ```diff !Line: 37 - information: Include file: "shylu.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L38-L43 ```diff !Line: 38 - information: Include file: "shylu_util.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L39-L44 ```diff !Line: 39 - information: Include file: "ShyLU_DDCore_config.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L40-L45 ```diff !Line: 40 - information: Include file: "shylu_partition_interface.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp#L41-L46 ```diff !Line: 41 - information: Include file: "shylu_directsolver_interface.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L17-L22 ```diff !Line: 17 - information: Include file: "Isorropia_config.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L29-L34 ```diff !Line: 29 - information: Include file: "Teuchos_GlobalMPISession.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L30-L35 ```diff !Line: 30 - information: Include file: "Teuchos_XMLParameterListHelpers.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L31-L36 ```diff !Line: 31 - information: Include file: "Teuchos_RCP.hpp" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L33-L38 ```diff !Line: 33 - information: Include file: "shylu.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L34-L39 ```diff !Line: 34 - information: Include file: "shylu_util.h" not found. [missingInclude] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L63-L68 ```diff !Line: 63 - style: The scope of the variable 'pass' can be reduced. [variableScope] ```
https://github.com/NexGenAnalytics/Trilinos/blob/744a5f3dad4ab7443e424610758c794fb415a2c1/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp#L64-L69 ```diff !Line: 64 - style: The scope of the variable 'fail' can be reduced. [variableScope] ```

---

[cwschilly]

I am having difficulty configuring Trilinos to actually build the shylu_dd/core directory so that I can build/test these tests. I'll leave this PR as is for now

[JacobDomagala]

Add:

-D Trilinos_ENABLE_Zoltan2=OFF \      
-D Trilinos_ENABLE_Zoltan2Core=ON \

Should work