search

NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
0 stars 2 forks source link

#210: Belos: replace hb reader tpetra #214

Open tlamonthezie opened 1 year ago

tlamonthezie commented 1 year ago

Fixes #210

IMPORTANT : Prerequities before requesting PR to trilinos/trilinos:develop

Because this PR is modifying previous PR's - and some are still i review on trilinos/trilinos:develop:

github-actions[bot] commented 1 year ago

:zap: Code quality check :zap:

:red_circle: clang-tidy found 37 issues! Click here to see details.
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockCG/BlockCGTpetraExFile.cpp#L117-L122 ```diff !Line: 117 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockCG/PseudoBlockCGTpetraExFile.cpp#L117-L122 ```diff !Line: 117 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockCG/PseudoBlockCGTpetraExFile.cpp#L133-L138 ```diff !Line: 133 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] !Line: 282 - note: +1 !Line: 155 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 159 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 167 - note: +1, nesting level increased to 1 !Line: 216 - note: +3, including nesting penalty of 2, nesting level increased to 3 ``` https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp#L124-L129 ```diff !Line: 124 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp#L133-L138 ```diff !Line: 133 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp#L133-L138 ```diff !Line: 133 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp#L167-L172 ```diff !Line: 167 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp#L216-L221 ```diff !Line: 216 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp#L122-L127 ```diff !Line: 122 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp#L143-L148 ```diff !Line: 143 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp#L143-L148 ```diff !Line: 143 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp#L145-L150 ```diff !Line: 145 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp#L222-L227 ```diff !Line: 222 - warning: variable 'resid' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L131-L136 ```diff !Line: 131 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp#L131-L136 ```diff !Line: 131 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/BiCGStab/test_bicgstab_hb.cpp#L123-L128 ```diff !Line: 123 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/BiCGStab/test_bicgstab_hb.cpp#L123-L128 ```diff !Line: 123 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp#L121-L126 ```diff !Line: 121 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp#L142-L147 ```diff !Line: 142 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp#L142-L147 ```diff !Line: 142 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp#L144-L149 ```diff !Line: 144 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp#L119-L124 ```diff !Line: 119 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp#L139-L144 ```diff !Line: 139 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp#L139-L144 ```diff !Line: 139 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp#L141-L146 ```diff !Line: 141 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp#L210-L215 ```diff !Line: 210 - warning: variable 'resid' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L90-L95 ```diff !Line: 90 - warning: function 'getCmdLineArgs' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L90-L95 ```diff !Line: 90 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L167-L172 ```diff !Line: 167 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L170-L175 ```diff !Line: 170 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L173-L178 ```diff !Line: 173 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L179-L184 ```diff !Line: 179 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L208-L213 ```diff !Line: 208 - warning: parameter name 'M' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L209-L214 ```diff !Line: 209 - warning: parameter 'debugOut' is unused [misc-unused-parameters] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp#L229-L234 ```diff !Line: 229 - warning: parameter name 'M' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/LSQR/LSQRTpetraExFile.cpp#L154-L159 ```diff !Line: 154 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/6b8ca475d5e34e3859681e00f83bbccd484067d5/packages/belos/tpetra/example/LSQR/LSQRTpetraExFile.cpp#L154-L159 ```diff !Line: 154 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```