search

NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
0 stars 2 forks source link

#215: Anasazi: Provide `Tpetra` version of GeneralizedDavidson directory #216

Closed cwschilly closed 1 year ago

cwschilly commented 1 year ago

Fixes #215

This PR creates the following tests in the tpetra/test/GeneralizedDavidson directory:

cxx_main_nh.cpp is modeled after the current test in the Epetra test directory (basically a one-to-one conversion, changing E's to T's)

cxx_main.cpp and cxx_main_lap.cpp are modeled after the tests of other solvers in the Tpetra test directory. Since the GeneralizedDavidson solver does not support complex types, cxx_main.cpp uses the same logic as the cxx_main_complex.cpp tests for the other solvers, but uses ST=double instead.

github-actions[bot] commented 1 year ago

:zap: Code quality check :zap:

:red_circle: clang-tidy found 184 issues! Click here to see details.
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L76-L81 ```diff !Line: 76 - warning: function 'run' has cognitive complexity of 46 (threshold 25) [readability-function-cognitive-complexity] !Line: 120 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 123 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 125 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 135 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 139 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 144 - note: +1, nesting level increased to 1 !Line: 154 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 154 - note: +1 !Line: 155 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 164 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 168 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 169 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 176 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 200 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 201 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 210 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 213 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 234 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 238 - note: +1 !Line: 240 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 240 - note: +1 !Line: 249 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 258 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 266 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 279 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 280 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 284 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 288 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 293 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 294 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 302 - note: +1, including nesting penalty of 0, nesting level increased to 1 ``` https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L76-L81 ```diff !Line: 76 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L94-L99 ```diff !Line: 94 - warning: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L99-L104 ```diff !Line: 99 - warning: variable 'tpetraScope' of type 'Tpetra::ScopeGuard' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L101-L106 ```diff !Line: 101 - warning: variable 'ONE' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L104-L109 ```diff !Line: 104 - warning: variable 'comm' of type 'RCP>' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L107-L112 ```diff !Line: 107 - warning: variable 'testFailed' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L112-L117 ```diff !Line: 112 - warning: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L113-L118 ```diff !Line: 113 - warning: variable 'blockSize' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L114-L119 ```diff !Line: 114 - warning: 1.0e-6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L116-L121 ```diff !Line: 116 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L119-L124 ```diff !Line: 119 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L120-L125 ```diff !Line: 120 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L123-L128 ```diff !Line: 123 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L130-L135 ```diff !Line: 130 - warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L130-L135 ```diff !Line: 130 - warning: variable 'dim' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L130-L135 ```diff !Line: 130 - warning: variable 'dim2' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L130-L135 ```diff !Line: 130 - warning: variable 'nnz' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L131-L136 ```diff !Line: 131 - warning: variable 'rnnzmax' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L132-L137 ```diff !Line: 132 - warning: variable 'dvals' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L133-L138 ```diff !Line: 133 - warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L133-L138 ```diff !Line: 133 - warning: variable 'colptr' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L133-L138 ```diff !Line: 133 - warning: variable 'rowind' is not initialized [cppcoreguidelines-init-variables] !Line: 139 - note: inferred assignment of ID-dependent value from ID-dependent [altera-id-dependent-backward-branch] ``` https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L138-L143 ```diff !Line: 138 - warning: variable 'rnnz' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L139-L144 ```diff !Line: 139 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L139-L144 ```diff !Line: 139 - warning: backward branch (for loop) is ID-dependent due to variable reference to 'ri' and may cause performance degradation [altera-id-dependent-backward-branch] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L139-L144 ```diff !Line: 139 - warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L139-L144 ```diff !Line: 139 - warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L162-L167 ```diff !Line: 162 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L163-L168 ```diff !Line: 163 - warning: variable 'K' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L163-L168 ```diff !Line: 163 - warning: variable name 'K' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L166-L171 ```diff !Line: 166 - warning: variable 'dptr' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L168-L173 ```diff !Line: 168 - warning: loop variable name 'c' is too short, expected at least 2 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L169-L174 ```diff !Line: 169 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L169-L174 ```diff !Line: 169 - warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L169-L174 ```diff !Line: 169 - warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L179-L184 ```diff !Line: 179 - warning: do not manage memory manually; use RAII [cppcoreguidelines-no-malloc,hicpp-no-malloc] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L179-L184 ```diff !Line: 179 - warning: calling legacy resource function without passing a 'gsl::owner<>' [cppcoreguidelines-owning-memory] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L180-L185 ```diff !Line: 180 - warning: do not manage memory manually; use RAII [cppcoreguidelines-no-malloc,hicpp-no-malloc] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L180-L185 ```diff !Line: 180 - warning: calling legacy resource function without passing a 'gsl::owner<>' [cppcoreguidelines-owning-memory] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L185-L190 ```diff !Line: 185 - warning: variable 'ivec' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L189-L194 ```diff !Line: 189 - warning: variable 'problem' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L200-L205 ```diff !Line: 200 - warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L218-L223 ```diff !Line: 218 - warning: variable 'maxRestarts' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L218-L223 ```diff !Line: 218 - warning: 25 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L219-L224 ```diff !Line: 219 - warning: variable 'maxDim' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L219-L224 ```diff !Line: 219 - warning: 50 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L231-L236 ```diff !Line: 231 - warning: variable 'MySolverMgr' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L254-L259 ```diff !Line: 254 - warning: variable 'sol' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L255-L260 ```diff !Line: 255 - warning: variable 'evecs' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L259-L264 ```diff !Line: 259 - warning: variable name 'os' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L261-L266 ```diff !Line: 261 - warning: 6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L264-L269 ```diff !Line: 264 - warning: variable 'normV' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L265-L270 ```diff !Line: 265 - warning: variable 'T' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L265-L270 ```diff !Line: 265 - warning: variable name 'T' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L266-L271 ```diff !Line: 266 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L269-L274 ```diff !Line: 269 - warning: variable 'Kvecs' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L277-L282 ```diff !Line: 277 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L277-L282 ```diff !Line: 277 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L279-L284 ```diff !Line: 279 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L283-L288 ```diff !Line: 283 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main.cpp#L283-L288 ```diff !Line: 283 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L66-L71 ```diff !Line: 66 - warning: function 'run' has cognitive complexity of 70 (threshold 25) [readability-function-cognitive-complexity] !Line: 108 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 118 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 124 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 151 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 152 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 153 - note: +1 !Line: 156 - note: +1, nesting level increased to 2 !Line: 157 - note: +1 !Line: 160 - note: +1, nesting level increased to 2 !Line: 165 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 172 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 196 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 198 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 206 - note: +1, nesting level increased to 2 !Line: 214 - note: +1, nesting level increased to 2 !Line: 222 - note: +1, nesting level increased to 2 !Line: 230 - note: +1, nesting level increased to 2 !Line: 237 - note: +1, nesting level increased to 2 !Line: 245 - note: +1, nesting level increased to 2 !Line: 253 - note: +1, nesting level increased to 2 !Line: 262 - note: +1, nesting level increased to 2 !Line: 276 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 283 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 302 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 305 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 322 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 331 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 349 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 350 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 350 - note: +1 !Line: 356 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 363 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 382 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 382 - note: +1 !Line: 390 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 398 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 415 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 416 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 432 - note: +1, nesting level increased to 3 !Line: 471 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 471 - note: +1 !Line: 478 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 488 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 488 - note: +1 !Line: 489 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 491 - note: +1, nesting level increased to 2 !Line: 495 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 495 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 495 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 495 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 495 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 495 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 495 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 497 - note: +1, including nesting penalty of 0, nesting level increased to 1 ``` https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L66-L71 ```diff !Line: 66 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L89-L94 ```diff !Line: 89 - warning: variable 'mpiSession' of type 'Teuchos::GlobalMPISession' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L98-L103 ```diff !Line: 98 - warning: variable 'boolret' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L104-L109 ```diff !Line: 104 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L107-L112 ```diff !Line: 107 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L108-L113 ```diff !Line: 108 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L109-L114 ```diff !Line: 109 - warning: throwing an exception whose type 'int' is not derived from 'std::exception' [hicpp-exception-baseclass] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L113-L118 ```diff !Line: 113 - warning: variable 'nx' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L113-L118 ```diff !Line: 113 - warning: variable name 'nx' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L113-L118 ```diff !Line: 113 - warning: 10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L114-L119 ```diff !Line: 114 - warning: variable 'NumGlobalElements' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L122-L127 ```diff !Line: 122 - warning: variable 'Map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L137-L142 ```diff !Line: 137 - warning: variable 'NumNz' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L151-L156 ```diff !Line: 151 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L161-L166 ```diff !Line: 161 - warning: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L170-L175 ```diff !Line: 170 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L170-L175 ```diff !Line: 170 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L179-L184 ```diff !Line: 179 - warning: variable 'rho' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L182-L187 ```diff !Line: 182 - warning: variable 'one' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L183-L188 ```diff !Line: 183 - warning: variable 'Indices' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L184-L189 ```diff !Line: 184 - warning: variable 'h' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L184-L189 ```diff !Line: 184 - warning: variable name 'h' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L185-L190 ```diff !Line: 185 - warning: variable 'h2' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L185-L190 ```diff !Line: 185 - warning: variable name 'h2' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L186-L191 ```diff !Line: 186 - warning: variable 'c' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L186-L191 ```diff !Line: 186 - warning: variable name 'c' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L187-L192 ```diff !Line: 187 - warning: variable 'val0' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L188-L193 ```diff !Line: 188 - warning: variable 'val1' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L189-L194 ```diff !Line: 189 - warning: variable 'val2' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L190-L195 ```diff !Line: 190 - warning: variable 'val3' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L191-L196 ```diff !Line: 191 - warning: variable 'Values0' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L192-L197 ```diff !Line: 192 - warning: variable 'diag' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L194-L199 ```diff !Line: 194 - warning: variable 'NumEntries' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L196-L201 ```diff !Line: 196 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L196-L201 ```diff !Line: 196 - warning: this loop is infinite; none of its condition variables (NumMyElements) are updated in the loop body [bugprone-infinite-loop] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L196-L201 ```diff !Line: 196 - warning: variable 'i' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L294-L299 ```diff !Line: 294 - warning: variable 'blockSize' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L295-L300 ```diff !Line: 295 - warning: variable 'maxDim' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L295-L300 ```diff !Line: 295 - warning: 50 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L296-L301 ```diff !Line: 296 - warning: variable 'restartDim' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L296-L301 ```diff !Line: 296 - warning: 10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L297-L302 ```diff !Line: 297 - warning: variable 'maxRestarts' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L297-L302 ```diff !Line: 297 - warning: 500 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L298-L303 ```diff !Line: 298 - warning: 1e-08 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L328-L333 ```diff !Line: 328 - warning: variable 'ivec' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L329-L334 ```diff !Line: 329 - warning: variable 'ivec' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L336-L341 ```diff !Line: 336 - warning: variable 'MyProblem' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L349-L354 ```diff !Line: 349 - warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L361-L366 ```diff !Line: 361 - warning: variable 'MySolverMgr' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L375-L380 ```diff !Line: 375 - warning: variable 'sol' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L376-L381 ```diff !Line: 376 - warning: variable 'evals' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L377-L382 ```diff !Line: 377 - warning: variable 'evecs' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L378-L383 ```diff !Line: 378 - warning: variable 'index' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L383-L388 ```diff !Line: 383 - warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L386-L391 ```diff !Line: 386 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L387-L392 ```diff !Line: 387 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L390-L395 ```diff !Line: 390 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L391-L396 ```diff !Line: 391 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L392-L397 ```diff !Line: 392 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L400-L405 ```diff !Line: 400 - warning: variable 'lapack' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L401-L406 ```diff !Line: 401 - warning: variable 'normA' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L404-L409 ```diff !Line: 404 - warning: variable name 'i' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L405-L410 ```diff !Line: 405 - warning: variable 'curind' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L406-L411 ```diff !Line: 406 - warning: variable 'resnorm' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L407-L412 ```diff !Line: 407 - warning: variable 'tempAevec' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L408-L413 ```diff !Line: 408 - warning: variable 'evecr' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L409-L414 ```diff !Line: 409 - warning: variable 'Aevec' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L414-L419 ```diff !Line: 414 - warning: variable 'Breal' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L415-L420 ```diff !Line: 415 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L415-L420 ```diff !Line: 415 - warning: backward branch (while loop) is ID-dependent due to variable reference to 'i' and may cause performance degradation [altera-id-dependent-backward-branch] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L474-L479 ```diff !Line: 474 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L475-L480 ```diff !Line: 475 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L476-L481 ```diff !Line: 476 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L478-L483 ```diff !Line: 478 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L479-L484 ```diff !Line: 479 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L480-L485 ```diff !Line: 480 - warning: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L481-L486 ```diff !Line: 481 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L489-L494 ```diff !Line: 489 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_nh.cpp#L491-L496 ```diff !Line: 491 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L59-L64 ```diff !Line: 59 - warning: function 'run' has cognitive complexity of 32 (threshold 25) [readability-function-cognitive-complexity] !Line: 109 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 112 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 114 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 126 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 127 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 134 - note: +1, nesting level increased to 1 !Line: 135 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 160 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 161 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 170 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 173 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 194 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 203 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 211 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 224 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 225 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 229 - note: +3, including nesting penalty of 2, nesting level increased to 3 !Line: 233 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 238 - note: +1, including nesting penalty of 0, nesting level increased to 1 !Line: 239 - note: +2, including nesting penalty of 1, nesting level increased to 2 !Line: 247 - note: +1, including nesting penalty of 0, nesting level increased to 1 ``` https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L59-L64 ```diff !Line: 59 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L83-L88 ```diff !Line: 83 - warning: variable 'ONE' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L85-L90 ```diff !Line: 85 - warning: variable 'tpetraScope' of type 'Tpetra::ScopeGuard' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L86-L91 ```diff !Line: 86 - warning: variable 'comm' of type 'RCP>' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L91-L96 ```diff !Line: 91 - warning: variable 'testFailed' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L95-L100 ```diff !Line: 95 - warning: 5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L97-L102 ```diff !Line: 97 - warning: 1.0e-6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L98-L103 ```diff !Line: 98 - warning: 25 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L99-L104 ```diff !Line: 99 - warning: variable 'maxDim' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L99-L104 ```diff !Line: 99 - warning: 50 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L101-L106 ```diff !Line: 101 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L104-L109 ```diff !Line: 104 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L105-L110 ```diff !Line: 105 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L106-L111 ```diff !Line: 106 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L107-L112 ```diff !Line: 107 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L109-L114 ```diff !Line: 109 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L112-L117 ```diff !Line: 112 - warning: statement should be inside braces [hicpp-braces-around-statements,readability-braces-around-statements] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L119-L124 ```diff !Line: 119 - warning: variable name 'nx' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L120-L125 ```diff !Line: 120 - warning: variable 'dim' of type 'int' can be declared 'const' [misc-const-correctness] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L123-L128 ```diff !Line: 123 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L124-L129 ```diff !Line: 124 - warning: variable 'K' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L124-L129 ```diff !Line: 124 - warning: variable name 'K' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L127-L132 ```diff !Line: 127 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L135-L140 ```diff !Line: 135 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L145-L150 ```diff !Line: 145 - warning: variable 'ivec' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L149-L154 ```diff !Line: 149 - warning: variable 'problem' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L189-L194 ```diff !Line: 189 - warning: variable 'MySolverMgr' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L199-L204 ```diff !Line: 199 - warning: variable 'sol' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L200-L205 ```diff !Line: 200 - warning: variable 'evecs' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L204-L209 ```diff !Line: 204 - warning: variable name 'os' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L206-L211 ```diff !Line: 206 - warning: 6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L209-L214 ```diff !Line: 209 - warning: variable 'normV' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L210-L215 ```diff !Line: 210 - warning: variable 'T' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L210-L215 ```diff !Line: 210 - warning: variable name 'T' is too short, expected at least 3 characters [readability-identifier-length] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L211-L216 ```diff !Line: 211 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L214-L219 ```diff !Line: 214 - warning: variable 'Kvecs' is not initialized [cppcoreguidelines-init-variables] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L222-L227 ```diff !Line: 222 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L222-L227 ```diff !Line: 222 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L224-L229 ```diff !Line: 224 - warning: kernel performance could be improved by unrolling this loop with a '#pragma unroll' directive [altera-unroll-loops] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L228-L233 ```diff !Line: 228 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```
https://github.com/NexGenAnalytics/Trilinos/blob/dde10437b1f58bac2152f9e5a4cd3d8bc09641dd/packages/anasazi/tpetra/test/GeneralizedDavidson/cxx_main_lap.cpp#L228-L233 ```diff !Line: 228 - warning: 20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers] ```

cwschilly commented 1 year ago

@stmcgovern This PR is ready for review

cwschilly commented 1 year ago

I am going to try creating a cxx_main_complex.cpp file, like the other test directories, as a way of getting around Anasazi::ModeLaplace1DQ1

cwschilly commented 1 year ago

The GeneralizedDavidson solver does not support complex value types, so instead I have created cxx_main.cpp that uses the same logic as the other cxx_main_complex.cpp files in the Tpetra test directory, but uses ST = double instead.

I have also created cxx_main_lap.cpp (to echo the other solvers in the Tpetra test directory).