search

NexGenAnalytics / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
0 stars 2 forks source link

46 tpetra multi vector adapter #57

Open mperrinel opened 1 year ago

mperrinel commented 1 year ago

Fixed https://github.com/NexGenAnalytics/Trilinos/issues/46

JacobDomagala commented 1 year ago

Is this ready to be reviewed? TpetraMultiVectorAdapter should provide new API (Host/Device) and there's no need to define the old one (we could rely on base implementation or throw exception saying this API is deprecated and point to new one).

mperrinel commented 1 year ago

TpetraMultiVectorAdapter is the tpetra conversion of XpetraMultiVectorAdapter. It has been started on the top of NGA-FY23-develop which doesn't contain new API (Host/Device) on VectorAdapter (need to wait for the PR validation). We can indeed wait for it in order to rebase the PR. For the need of defining the old one. It is a good point. For me it is just an intermediary step which correspond to the conversion from Xpetra to Tpetra.

JacobDomagala commented 1 year ago

Unless I'm missing something, the only new part introduced by the VectorAdapter is Elements getter, the rest is already on develop and is the part of BaseAdapter. But all right, I'll wait when it's ready : )