search

NexGenAnalytics / WorkVisualizer

High-level, interactive, visual performance analysis for High-Performance Computing (HPC)
https://www.workvisualizer.com/
Other
3 stars 0 forks source link

#7: Add plot interactivity and selective filtering #24

Closed cwschilly closed 4 months ago

cwschilly commented 5 months ago

Fixes #7 Fixes #25 Fixes #26 (kind of--the logo takes a moment to pop now. there may be a better solution)

cwschilly commented 4 months ago

@pierrepebay I'm hitting a bug here and I'm not sure how to fix it.

Steps to Reproduce

Open the spacetime plot. With "Show Duration" turned off, everything works as expected (try zooming in and out a few times--it should work normally).

If you select "Show Duration", the brush-to-zoom feature doesn't work correctly.

  1. As soon as you mouse over a data point, the option to brush goes away[^1]
  2. If you avoid mousing over any points, you can only zoom in once before brush stops working

The Problem

I believe that the problem stems from the way I'm setting the width attribute of the rectangles.

If I comment out the calls to .attr('width': ...) in mouseenter, mouseleave, and updateChart, then the brushing/zooming works properly (of course, the function durations are then incorrect because it doesn't scale correctly).

If you have time, could you take a look at this and let me know what you think?

[^1]: Normally, the cursor over "empty" space on the plot should resemble a target/selector to indicate that brushing is enabled