Created rate limit middleware

NexdApp / nexd-backend

MIT License

38 stars 3 forks source link

Open JackVarney opened 4 years ago

JackVarney commented 4 years ago

WIP...

Wanted to get feedback on a couple of issues

Would this be better implemented else where (e.g. whoever hosts this might have their own rate limiting capabilities)?
I've arbitrarily set it to default to 100 requests every 15 minutes and for auth 10 every 30 minutes. What actually would be the ideal config here?
Finally, would this be better set as an environment variable or in some config somewhere?

JackVarney commented 4 years ago

@fanick-ber

Is this more inline with what you was thinking?

JackVarney commented 4 years ago

I think it was because I was creating a new instance of rate limit each time lol.

Its using the same version everytime now if you'd like to give it another go.

JackVarney commented 4 years ago

@fanick-ber

f10l commented 4 years ago

Thanks @JackVarney , I will test it tomorrow! :-)