Nexela / PickerExtended

MIT License
12 stars 16 forks source link

[0.16.1 / 3.0.0] R to rotate held items also rotates placed entities when Picker Extended is enabled. #61

Closed dewiniaid closed 6 years ago

dewiniaid commented 6 years ago

Was about to post this on the official forums before I realized the behavior only happened with Picker Extended enabled:

In Factorio 0.15.x, hitting R to to rotate transport belts being placed would only rotate those belts. If the cursor happened to be over another transport belt at the same time, that belt would not be rotated.

In 0.16.1, "R" will rotate both the held item [i]and[/i] the entity the cursor is over. Furthermore, the belt on the cursor will obscure the belt underneath it that is being rotated (possibly not in the same direction) to make it less noticeable that this is happening. Previously, R only rotated placed entities if the hand was empty (or maybe if it held a non-rotatable item?)

Nexela commented 6 years ago

Noted. Should be an easy fix to disable action when holding something in hand.

On Dec 14, 2017 1:00 AM, "Daniel Grace" notifications@github.com wrote:

Was about to post this on the official forums before I realized the behavior only happened with Picker Extended enabled:

In Factorio 0.15.x, hitting R to to rotate transport belts being placed would only rotate those belts. If the cursor happened to be over another transport belt at the same time, that belt would not be rotated.

In 0.16.1, "R" will rotate both the held item [i]and[/i] the entity the cursor is over. Furthermore, the belt on the cursor will obscure the belt underneath it that is being rotated (possibly not in the same direction) to make it less noticeable that this is happening. Previously, R only rotated placed entities if the hand was empty (or maybe if it held a non-rotatable item?)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Nexela/PickerExtended/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/ANUy4M4LrVnqsUZcJbROPcVIucVCMY1dks5tALl0gaJpZM4RBlVe .

dewiniaid commented 6 years ago

After confirming I'm using the latest version of PickerExtended and that my version actually includes e5db810c850c4be16514f71985934f03dded80bb, this issue still is very much present.

Nexela commented 6 years ago

Thanks for the follow up. Will address shortly