Nexela / PickerExtended

MIT License
12 stars 16 forks source link

Keybind failures #99

Closed OvermindDL1 closed 5 years ago

OvermindDL1 commented 5 years ago

Finally found out what was spamming my factorio log on startup with these errors:

 133.390 Warning ControlInput.cpp:270: Unknown control input string "PAD -"
 133.391 Warning ControlInput.cpp:270: Unknown control input string "PAD +"
 133.394 Warning ControlInput.cpp:270: Unknown control input string "PAD DELETE"
 133.394 Warning ControlInput.cpp:270: Unknown control input string "PAD 0"
 133.394 Warning ControlInput.cpp:270: Unknown control input string "SHIFT + PAD 0"
 133.396 Warning ControlInput.cpp:270: Unknown control input string "PAD +"
 133.396 Warning ControlInput.cpp:270: Unknown control input string "PAD 5"
 133.397 Warning ControlInput.cpp:270: Unknown control input string "PAD 6"
 133.397 Warning ControlInput.cpp:270: Unknown control input string "PAD 8"
 133.397 Warning ControlInput.cpp:270: Unknown control input string "PAD 9"
 133.397 Warning ControlInput.cpp:270: Unknown control input string "PAD 7"
 133.397 Warning ControlInput.cpp:270: Unknown control input string "PAD 2"
 133.397 Warning ControlInput.cpp:270: Unknown control input string "PAD 3"
 133.397 Warning ControlInput.cpp:270: Unknown control input string "PAD 1"
 133.398 Warning ControlInput.cpp:270: Unknown control input string "PAD 4"
 133.398 Warning ControlInput.cpp:270: Unknown control input string "PAD +"
 133.400 Warning ControlInput.cpp:270: Unknown control input string "CONTROL + SHIFT + ENTER"

Being this Picker Extended mod. Those aren't valid keybind definitions, specifically each of those should be mapped to (->):

PAD -                   -> KP_ADD
PAD +                   -> KP_SUBTRACT
PAD DELETE              -> KP_DECIMAL
PAD 0                   -> KP_INSERT
SHIFT + PAD 0           -> SHIFT + KP_INSERT
PAD 1                   -> KP_END
PAD 2                   -> KP_DOWN
PAD 3                   -> KP_NEXT
PAD 4                   -> KP_LEFT
PAD 5                   -> KP_BEGIN
PAD 6                   -> KP_RIGHT
PAD 7                   -> KP_HOME
PAD 8                   -> KP_UP
PAD 9                   -> KP_PRIOR
CONTROL + SHIFT + ENTER -> CONTROL + SHIFT + RETURN

And these do not change whether NumLock is on or off (as it shouldn't as it's reading the raw keycodes)

Figured this out by trying to use these keys in PickerExtended and they weren't doing anything at all, checked the keybindings and they were unbound, bound them based on the above and they all work properly now. See fixed keybindings at: https://overminddl1.com/Factorio/screenshots/PickerExtendedFixedKeyBindings.png Fixed Keybindings

Nexela commented 5 years ago

Should be fixed