search

NexiusTailer / Nex-AC

Anticheat system
https://pawn.wiki/index.php?/topic/27641-nex-ac/
GNU Lesser General Public License v3.0
212 stars 156 forks source link

Some minor fixes. #298

Closed Adib23704 closed 10 months ago

Adib23704 commented 10 months ago

Fixes are done because of the latest Community Compiler enforces the usage of const as well as it triggers error 017: undefined symbol "DEBUG_CODE_1"

NexiusTailer commented 10 months ago
  1. This doesn't fix const problem as with your changes now it wont compile on default samp compiler & includes
  2. You broke ru and by lang files by converting it to UTF-8, it's not supported in samp
  3. DEBUG_CODE's should only be declared if the #define DEBUG is added
Adib23704 commented 10 months ago

I converted nothing. GitHub did it :/

On Sat, Dec 2, 2023, 8:07 PM Nexius @.***> wrote:

  1. This doesn't fix const problem as with your changes it now wont compile on default samp compiler & includes.
  2. You broke ru and by lang files by converting it to UTF-8, it's not supported in samp
  3. DEBUG_CODEs should only be declared if the #define DEBUG is added

— Reply to this email directly, view it on GitHub https://github.com/NexiusTailer/Nex-AC/pull/298#issuecomment-1837156806, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALM5OH2XHUE5QHZFPP6JS6TYHMYZRAVCNFSM6AAAAABAD37J66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGE2TMOBQGY . You are receiving this because you authored the thread.Message ID: @.***>

NexiusTailer commented 10 months ago

Ok, still 1 and 3 are valid

Adib23704 commented 10 months ago

I mean when I was compiling it showed me undefined symbol DEBUG_CODE_1. I had to comment out #if defined DEBUG condition to get out of this error. (Same for other DEBUG_CODE vars)

For number 1, I don't know. Maybe you can check it out

On Sat, Dec 2, 2023, 8:09 PM Nexius @.***> wrote:

Ok, still 1 and 3 are valid

— Reply to this email directly, view it on GitHub https://github.com/NexiusTailer/Nex-AC/pull/298#issuecomment-1837157398, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALM5OH27ZZGPFWQKNEPAFGTYHMZDFAVCNFSM6AAAAABAD37J66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGE2TOMZZHA . You are receiving this because you authored the thread.Message ID: @.***>

NexiusTailer commented 10 months ago

I mean when I was compiling it showed me undefined symbol DEBUG_CODE_1. I had to comment out #if defined DEBUG condition to get out of this error. (Same for other DEBUG_CODE vars)

So you probably manually included lang file without adding #define DEBUG as readme says.

For number 1, I don't know. Maybe you can check it out

Yes I've already checked it and it's not the solution. Solution is to be in line with default samp includes and don't change it with breaking changes like samp-stdlib does.