search

NexiusTailer / Nex-AC

Anticheat system
https://pawn.wiki/index.php?/topic/27641-nex-ac/
GNU Lesser General Public License v3.0
212 stars 156 forks source link

RemovePlayerFromVehicle compatibility with open.mp #309

Closed Ljub1sa closed 4 months ago

Ljub1sa commented 4 months ago

When using RemovePlayerFromVehicle with added parameter force in open.mp includes, there is conflict

warning 202: number of arguments does not match definition

NexiusTailer commented 4 months ago

It's a wrong parameter since RemovePlayerFromVehicle cannot have anything than just playerid. It's obviously a design mistake from omp-stdlib project and should be fixed on their side.

Ljub1sa commented 4 months ago

That is new added parameter in open.mp, i think that's not a mistake by them?

NexiusTailer commented 4 months ago

No, it's definitely a mistake because if you look at RPC ID 71 (which implements RemovePlayerFromVehicle native), it doesn't have any other parameters than just recipient player ID. If omp libs/server implements some more parameters which somehow change the underlying RPC, that's a design mistake and must be corrected, since natives shouldn't mess up RPCs under them.