cannot change the application --type using app:update

Nexmo / nexmo-cli

Nexmo CLI (Command Line Interface)

https://nexmo.com

MIT License

78 stars 52 forks source link

cannot change the application --type using app:update #108

Closed kapekost closed 7 years ago

kapekost commented 7 years ago

Steps to reproduce

Create an app no optional type specified (should default to 'voice')
Try to modify the type to 'rtc' by using the app:update

Expected behavior

The application should now have a type of 'rtc'

Actual behavior

The application type is still 'voice'

System configuration

Node version: v5.12.0

NPM version: 3.8.6

Operating system: Mac OS Sierra

sammachin commented 7 years ago

Now that we have more than one possible type of application I think type should be a mandatory field without a default.

cbetta commented 7 years ago

@sammachin @kapekost the problem for this actually lies in the Node library, and the docs:

https://github.com/Nexmo/nexmo-node/blob/bc368fc286e1b5a473f25728f6beb117615484be/src/index.js#L359

https://docs.nexmo.com/tools/application-api/api-reference#urparameters

Currently, both say that the only valid param is 'voice', and it's enforced in the SDK as such. I assume there are more, undocumented values? If so can I get a full list?

kapekost commented 7 years ago

afaik only 'rtc' type is to be added, but also will require the callback urls to be optional

cbetta commented 7 years ago

@kapekost hmmm, that makes things a bit messy.

Can you actually change an app from 1 type to the other? Is that a realistic thing?

kapekost commented 7 years ago

@leggetter might have a better insight to this, or maybe just a respond saying that the type is not changed would be ok for now