Closed AlexLakatos closed 7 years ago
@cbetta - Thanks for the comment. I'd completely missed that in doing this we lose the numbers:list
command which is a breaking change.
Probably a good idea to list what something fixes when it's marked as a FIX ;)
Also what's up with the commit history here? It's removing one feature with 6 commits, and yet the README not the CHANGELOG is updated.
@AlexLakatos so the reason so much code seems duplicate in bin.js
is because of this issue:
https://github.com/Nexmo/nexmo-cli/issues/14
If you found a solution to this we should probably deduplicate most secondary aliases. I added a lot of aliases to help remove the need to remember if every command is singular (number) or plural (numbers).
@AlexLakatos ok to close this issue and open a ticket for the number:buy
problem?
@cbetta not really. I'll just change scope to re-add numbers:list
and the nl
alias to it. Still need to release 0.3.9 Will log a separate issue to check all aliases in the app though.
@AlexLakatos can we fix the commit history for this branch? It seems a bit messed up. Probably based on wrong base commit
@cbetta wouldn't that be fixed anyway with a squash and merge?
@AlexLakatos as long as we do a squash ;)
What has this been replaced with?