search

Nexmo / nexmo-cli

Nexmo CLI (Command Line Interface)
https://nexmo.com
MIT License
78 stars 52 forks source link

Added pattern support to`numbers:list` #140

Closed AlexLakatos closed 7 years ago

cbetta commented 7 years ago

What has this been replaced with?

leggetter commented 7 years ago

@cbetta - Thanks for the comment. I'd completely missed that in doing this we lose the numbers:list command which is a breaking change.

cbetta commented 7 years ago

Probably a good idea to list what something fixes when it's marked as a FIX ;)

cbetta commented 7 years ago

Also what's up with the commit history here? It's removing one feature with 6 commits, and yet the README not the CHANGELOG is updated.

cbetta commented 7 years ago

@AlexLakatos so the reason so much code seems duplicate in bin.js is because of this issue:

https://github.com/Nexmo/nexmo-cli/issues/14

If you found a solution to this we should probably deduplicate most secondary aliases. I added a lot of aliases to help remove the need to remember if every command is singular (number) or plural (numbers).

cbetta commented 7 years ago

@AlexLakatos ok to close this issue and open a ticket for the number:buy problem?

AlexLakatos commented 7 years ago

@cbetta not really. I'll just change scope to re-add numbers:list and the nl alias to it. Still need to release 0.3.9 Will log a separate issue to check all aliases in the app though.

cbetta commented 7 years ago

@AlexLakatos can we fix the commit history for this branch? It seems a bit messed up. Probably based on wrong base commit

AlexLakatos commented 7 years ago

@cbetta wouldn't that be fixed anyway with a squash and merge?

cbetta commented 7 years ago

@AlexLakatos as long as we do a squash ;)