search

Nexmo / nexmo-cli

Nexmo CLI (Command Line Interface)
https://nexmo.com
MIT License
78 stars 52 forks source link

Adding <api_key> <api_secret> to nexmo setup error msg. Closes #209 #210

Closed michaeljolley closed 4 years ago

michaeljolley commented 4 years ago

Summary

Modified the error message that states:

Could not initialize Nexmo library. Please run 'nexmo setup' to setup the CLI correctly.

To read:

Could not initialize Nexmo library. Please run 'nexmo setup ' to setup the CLI correctly.

Also, updated npm packages to remove dependencies on library versions with critical or high security issues.

codecov-io commented 4 years ago

Codecov Report

Merging #210 into master will not change coverage. The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files           6        6           
  Lines         401      401           
=======================================
  Hits          351      351           
  Misses         50       50
Impacted Files Coverage Δ
src/client.js 76.47% <50%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80419e5...5714b59. Read the comment docs.

AlexLakatos commented 4 years ago

I don't see the nexmo setup syntax changing any time soon, so I think we're good to merge this when you want.