Nexmo / nexmo-cli

Nexmo CLI (Command Line Interface)

https://nexmo.com

MIT License

78 stars 52 forks source link

Added commands to gracefully report account information #225

Closed sudiptog81 closed 3 years ago

sudiptog81 commented 4 years ago

Summary

Tries to partly address #223. Added missing alias in README.md for the account command. The API key and secret can be reported separately using nexmo account:key and nexmo account:secret with the contributions in this PR. Added test cases to handle the new commands.

codecov-commenter commented 4 years ago

Codecov Report

Merging #225 into master will decrease coverage by 0.37%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   87.53%   87.16%   -0.38%     
==========================================
  Files           6        6              
  Lines         401      405       +4     
==========================================
+ Hits          351      353       +2     
- Misses         50       52       +2

Impacted Files	Coverage Δ
src/request.js	`77.01% <0.00%> (-0.97%)`	:arrow_down:
src/response.js	`92.79% <100.00%> (+0.13%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05e8a96...6be04a4. Read the comment docs.

kellyjandrews commented 3 years ago

Hey @sudiptog81 - I'll take a look at these this week. Thanks!

sudiptog81 commented 3 years ago

Sure! Would address the requested changes and revert all breaking changes as soon as able.

codecov-io commented 3 years ago

Codecov Report

Merging #225 into master will decrease coverage by 0.37%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   87.53%   87.16%   -0.38%     
==========================================
  Files           6        6              
  Lines         401      405       +4     
==========================================
+ Hits          351      353       +2     
- Misses         50       52       +2

Impacted Files	Coverage Δ
src/request.js	`77.01% <0.00%> (-0.97%)`	:arrow_down:
src/response.js	`92.79% <100.00%> (+0.13%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05e8a96...e3c8580. Read the comment docs.

lornajane commented 3 years ago

I'll leave it with you to release at some point, @kellyjandrews