search

Nexmo / nexmo-cli

Nexmo CLI (Command Line Interface)
https://nexmo.com
MIT License
78 stars 52 forks source link

feat: allow for api key/secret as arg for sms #229

Closed WilliamHYZhang closed 3 years ago

WilliamHYZhang commented 3 years ago

Summary

Want to include API key/secret as arguments #86

Other Information

Not sure if this works, someone please verify!

Thanks for contributing to the Nexmo CLI!

codecov-commenter commented 3 years ago

Codecov Report

Merging #229 into master will decrease coverage by 0.18%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   87.53%   87.34%   -0.19%     
==========================================
  Files           6        6              
  Lines         401      403       +2     
==========================================
+ Hits          351      352       +1     
- Misses         50       51       +1
Impacted Files Coverage Δ
src/request.js 77.63% <50.00%> (-0.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 867cd8e...f3d2c87. Read the comment docs.

kellyjandrews commented 3 years ago

Thanks for this @WilliamHYZhang - I'll get it reviewed this week.