search

Nexmo / nexmo-cli

Nexmo CLI (Command Line Interface)
https://nexmo.com
MIT License
78 stars 52 forks source link

Lvn add remove fix #234

Closed kellyjandrews closed 3 years ago

kellyjandrews commented 3 years ago

Summary

Users are experiencing a Server Error response when attempting torun nexmo unlink:app .... This PR updates the command to process the unlink properly.

Other Information

The Application API changed, and no longer required the voiceApplicationType value, and was returning a 500 error from the server. The functions here are overloaded, however, and testing is unable to pick up on this issue directly. The tests have not been updated, as it would require significant modification to the code base to resolve testing issues. Will address testing issues in the future, or with v1.

codecov-io commented 3 years ago

Codecov Report

Merging #234 (55b7565) into master (1d76b7a) will decrease coverage by 0.21%. The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   87.16%   86.94%   -0.22%     
==========================================
  Files           6        6              
  Lines         405      406       +1     
==========================================
  Hits          353      353              
- Misses         52       53       +1
Impacted Files Coverage Δ
src/request.js 76.54% <20.00%> (-0.48%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d76b7a...55b7565. Read the comment docs.