Closed sammachin closed 8 years ago
Makes sense.
I suggest we modify the price:country non verbose response to be a range of the lowest and highest values returned by the API so for GB it should show 0.0314 - 0.0333 EUR
"response" or do we mean "output"?
On Mon, 20 Jun 2016, 10:19 Cristiano Betta, notifications@github.com wrote:
Makes sense.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Nexmo/nexmo-cli/issues/57#issuecomment-227091159, or mute the thread https://github.com/notifications/unsubscribe/AAUCr7lVELWsjz2KSS4oDYQfW5n-CtA4ks5qNlsagaJpZM4I5eKe .
whats the difference between response and output?
On Mon, Jun 20, 2016 at 10:23 AM Phil Leggetter notifications@github.com wrote:
I suggest we modify the price:country non verbose response to be a range of the lowest and highest values returned by the API so for GB it should show 0.0314 - 0.0333 EUR
"response" or do we mean "output"?
On Mon, 20 Jun 2016, 10:19 Cristiano Betta, notifications@github.com wrote:
Makes sense.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Nexmo/nexmo-cli/issues/57#issuecomment-227091159, or mute the thread < https://github.com/notifications/unsubscribe/AAUCr7lVELWsjz2KSS4oDYQfW5n-CtA4ks5qNlsagaJpZM4I5eKe
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Nexmo/nexmo-cli/issues/57#issuecomment-227092080, or mute the thread https://github.com/notifications/unsubscribe/AALc_V_a2SRv1CRFGl743UJN6WuuUG5dks5qNlwagaJpZM4I5eKe .
BTW when I designed the CLI the goal for the non verbose output has always been to be predictable so that it can be used in a Unix environment to be piped into other commands. For that reason 0.0314 EUR
is a lot more useful than a range. Are we sure we're happy to drop this?
whats the difference between response and output?
In the context of the nexmo-cli the response could be thought of as the response from the API that is being called or the output from the command. If we mean the latter then output
is clearer.
I suggest we modify the price:country non verbose response to be a range of the lowest and highest values returned by the API so for GB it should show 0.0314 - 0.0333 EUR
For purposes of my education, how is the range determined? Does this required two underlying API queries?
BTW when I designed the CLI the goal for the non verbose output has always been to be predictable so that it can be used in a Unix environment to be piped into other commands. For that reason 0.0314 EUR is a lot more useful than a range. Are we sure we're happy to drop this?
I guess it depends on whether "may mislead users causing additional support overhead" can be justified. Are there examples of this already? Could we instead just use the maximum possible cost/value?
fair point, To me the response from the Dev API and/or our pricing model, the perfect option would be to clean up the prices but I didn't get anywhere with that.
Just returning the max price might be another option, especially as there's usually very little variation, again we'd need to check if nay countries have a very high outlying price.
It would remain 1 API call.
Out of interest the website just shows the higher price for "All Networks" which adds weight to the case for showing the max, at least we would be consistent with the web site.
So maybe thats a better idea?
+1 for showing MAX price
For some counties (for example GB) the SMS Price can vary depending on the network being sent to, the default country price returned is 0.0314 whereas all the known mobile networks are 0.0333. (The 0.0314 is for
UNKNOWN
e.g. landlines)The problem for users is that the price:country command without -v just returns the default country price and in the UK case nearly all mobile will be slightly higher and may mislead users causing additional support overhead.
I suggest we modify the
price:country
non verbose response to be a range of the lowest and highest values returned by the API so for GB it should show0.0314 - 0.0333 EUR
The number specific price queries are unaffected as this will always be a single value returned from our rating system