search

Nexmo / nexmo-laravel

Add Vonage functionality such as SMS and voice calling to your Laravel app with this Laravel Service Provider.
MIT License
317 stars 79 forks source link

Laravel 8 support #46

Closed driesvints closed 4 years ago

driesvints commented 4 years ago

Needed for us to roll out Laravel 8 support for Nexmo Notification Channel: https://github.com/laravel/nexmo-notification-channel/pull/38

dragonmantank commented 4 years ago

We are going to have a BC breaking change here soon, we've changed a namespace and return type with SMS. What's the timeframe on Laravel 8? Might as well roll those two things together if possible.

driesvints commented 4 years ago

We're launching it on September 8. We can definitely also do a major release on our end if necessary.

dragonmantank commented 4 years ago

Awesome. Expect a PR from me within a few days then!

driesvints commented 4 years ago

Thanks Chris : )

driesvints commented 3 years ago

@dragonmantank hey Chris. Laravel 8 release is next week. Have you had time to look into that PR already? Shall we just do a 2.3.0 with Laravel 8 support? Then it's less pressure for you to work on a PR and we can do a next major release for laravel nexmo notificiation channel afterwards.

dragonmantank commented 3 years ago

Started working on the PR, but I'll have some other changes that will impact the mainline Nexmo Notifications package (including a brand rename to Vonage), so I'll work with you all on that once Laravel 8 comes out.

I'll cut 2.3.0 here in a moment, and do a larger PR for the next major Laravel/Laravel Notifications release

driesvints commented 3 years ago

@dragonmantank perfect! Thank you.